From: John Garry <john.g.garry@oracle.com>
To: "Daniel Wagner" <wagi@kernel.org>, "Jens Axboe" <axboe@kernel.dk>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, virtualization@lists.linux.dev,
linux-scsi@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
mpi3mr-linuxdrv.pdl@broadcom.com,
MPT-FusionLinux.pdl@broadcom.com, storagedev@microchip.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3 5/8] scsi: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues
Date: Wed, 13 Nov 2024 10:09:50 +0000 [thread overview]
Message-ID: <c06cdfae-8a0a-4c7e-83f2-c78196ad83ee@oracle.com> (raw)
In-Reply-To: <20241112-refactor-blk-affinity-helpers-v3-5-573bfca0cbd8@kernel.org>
On 12/11/2024 13:26, Daniel Wagner wrote:
> #include <linux/acpi.h>
> #include <linux/blk-mq.h>
> -#include <linux/blk-mq-pci.h>
> #include <linux/clk.h>
> #include <linux/debugfs.h>
> #include <linux/dmapool.h>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> index 4cd3a3eab6f1c47c962565a74cd7284dad1db12e..7858c807be5eacb70ded5ec9399c6531a4ef6116 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> @@ -3322,8 +3322,8 @@ static void hisi_sas_map_queues(struct Scsi_Host *shost)
> if (i == HCTX_TYPE_POLL)
> blk_mq_map_queues(qmap);
> else
> - blk_mq_pci_map_queues(qmap, hisi_hba->pci_dev,
> - BASE_VECTORS_V3_HW);
> + blk_mq_hctx_map_queues(qmap, &hisi_hba->pci_dev->dev,
nit: hisi_hba->dev could be used directly
> + BASE_VECTORS_V3_HW);
looks ok apart from that
> qoff += qmap->nr_queues;
> }
next prev parent reply other threads:[~2024-11-13 10:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 13:26 [PATCH v3 0/8] blk: refactor queue affinity helpers Daniel Wagner
2024-11-12 13:26 ` [PATCH v3 1/8] driver core: bus: add irq_get_affinity callback to bus_type Daniel Wagner
2024-11-12 16:54 ` Christoph Hellwig
2024-11-13 9:46 ` Hannes Reinecke
2024-11-13 10:16 ` John Garry
2024-11-13 12:36 ` Daniel Wagner
2024-11-13 13:44 ` John Garry
2024-11-13 13:54 ` Greg Kroah-Hartman
2024-11-13 14:12 ` John Garry
2024-11-13 14:24 ` Greg Kroah-Hartman
2024-11-13 14:30 ` Christoph Hellwig
2024-11-12 13:26 ` [PATCH v3 2/8] PCI: hookup irq_get_affinity callback Daniel Wagner
2024-11-12 16:54 ` Christoph Hellwig
2024-11-13 9:47 ` Hannes Reinecke
2024-11-12 13:26 ` [PATCH v3 3/8] virtio: " Daniel Wagner
2024-11-12 16:55 ` Christoph Hellwig
2024-11-12 22:07 ` kernel test robot
2024-11-13 9:47 ` Hannes Reinecke
2024-11-12 13:26 ` [PATCH v3 4/8] blk-mp: introduce blk_mq_hctx_map_queues Daniel Wagner
2024-11-12 13:58 ` Greg Kroah-Hartman
2024-11-12 15:33 ` Daniel Wagner
2024-11-12 15:42 ` Greg Kroah-Hartman
2024-11-12 16:15 ` Daniel Wagner
2024-11-12 16:53 ` Greg Kroah-Hartman
2024-11-12 16:56 ` Christoph Hellwig
2024-11-12 18:25 ` Daniel Wagner
2024-11-13 9:48 ` Hannes Reinecke
2024-11-12 13:26 ` [PATCH v3 5/8] scsi: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues Daniel Wagner
2024-11-13 9:49 ` Hannes Reinecke
2024-11-13 10:09 ` John Garry [this message]
2024-11-12 13:26 ` [PATCH v3 6/8] nvme: " Daniel Wagner
2024-11-13 9:50 ` Hannes Reinecke
2024-11-12 13:26 ` [PATCH v3 7/8] virtio: blk/scsi: replace blk_mq_virtio_map_queues " Daniel Wagner
2024-11-13 9:51 ` Hannes Reinecke
2024-11-12 13:26 ` [PATCH v3 8/8] blk-mq: remove unused queue mapping helpers Daniel Wagner
2024-11-13 9:52 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c06cdfae-8a0a-4c7e-83f2-c78196ad83ee@oracle.com \
--to=john.g.garry@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=mst@redhat.com \
--cc=sagi@grimberg.me \
--cc=storagedev@microchip.com \
--cc=virtualization@lists.linux.dev \
--cc=wagi@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).