virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: eperezma@redhat.com, virtualization@lists.linux-foundation.org,
	mst@redhat.com
Subject: Re: [PATCH v2 5/6] vdpa/mlx5: Add support for control VQ and MAC setting
Date: Thu, 19 Aug 2021 15:41:52 +0800	[thread overview]
Message-ID: <c08fb86b-29d1-6b79-c421-abc7b37e8a9c@redhat.com> (raw)
In-Reply-To: <20210819072438.GB166182@mtl-vdi-166.wap.labs.mlnx>


在 2021/8/19 下午3:24, Eli Cohen 写道:
>>>>> +	vringh_set_iotlb(&mvdev->cvq.vring, mvdev->cvq.iotlb, &mvdev->cvq.iommu_lock);
>>>>> +	err = iova_cache_get();
>>>> Any reason for using iova cache here?
>>> Isn't it required? Aren't we allocating buffers for the CVQ from
>>> iommu_iova kmem cache?
>> I may miss something here but which buffer did you refer here?
>>
> Aren't the data buffers for the control VQ allocated from this cache?


Sorry, but you mean the buffer managed by the virtio-net or the mlx5e here?

Thanks


>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2021-08-19  7:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210817060250.188705-1-elic@nvidia.com>
     [not found] ` <20210817060250.188705-3-elic@nvidia.com>
2021-08-19  3:32   ` [PATCH v2 2/6] vdpa/mlx5: function prototype modifications in preparation to control VQ Jason Wang
     [not found] ` <20210817060250.188705-4-elic@nvidia.com>
2021-08-19  3:37   ` [PATCH v2 3/6] vdpa/mlx5: Decouple virtqueue callback from struct mlx5_vdpa_virtqueue Jason Wang
     [not found] ` <20210817060250.188705-5-elic@nvidia.com>
2021-08-19  3:40   ` [PATCH v2 4/6] vdpa/mlx5: Ensure valid indices are provided Jason Wang
     [not found] ` <20210817060250.188705-6-elic@nvidia.com>
2021-08-19  4:04   ` [PATCH v2 5/6] vdpa/mlx5: Add support for control VQ and MAC setting Jason Wang
     [not found]     ` <20210819060641.GA161591@mtl-vdi-166.wap.labs.mlnx>
2021-08-19  7:12       ` Jason Wang
     [not found]         ` <20210819072145.GA166182@mtl-vdi-166.wap.labs.mlnx>
2021-08-19  7:37           ` Jason Wang
     [not found]           ` <20210819072438.GB166182@mtl-vdi-166.wap.labs.mlnx>
2021-08-19  7:41             ` Jason Wang [this message]
     [not found]               ` <20210819074819.GA167253@mtl-vdi-166.wap.labs.mlnx>
     [not found]                 ` <20210819081535.GB167253@mtl-vdi-166.wap.labs.mlnx>
2021-08-19  8:19                   ` Jason Wang
     [not found] ` <20210817060250.188705-7-elic@nvidia.com>
2021-08-19  4:07   ` [PATCH v2 6/6] vdpa/mlx5: Add multiqueue support Jason Wang
     [not found]     ` <20210819061547.GD161591@mtl-vdi-166.wap.labs.mlnx>
2021-08-19  7:12       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c08fb86b-29d1-6b79-c421-abc7b37e8a9c@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).