From: Jason Wang <jasowang@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 5/5] a vendor driver should not set _CONFIG_S_FAILED
Date: Wed, 26 Apr 2023 13:10:20 +0800 [thread overview]
Message-ID: <c130a02f-08d1-314c-859d-5a62ff01fb0f@redhat.com> (raw)
In-Reply-To: <20230331204854.20082-6-lingshan.zhu@intel.com>
在 2023/4/1 04:48, Zhu Lingshan 写道:
> VIRTIO_CONFIG_S_FAILED indicates the guest driver has given up
> the device due to fatal errors. So it is the guest decision,
> the vendor driver should not set this status to the device.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> ---
> drivers/vdpa/ifcvf/ifcvf_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> index 15c6157ee841..f228fba74c61 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> @@ -423,9 +423,7 @@ static void ifcvf_vdpa_set_status(struct vdpa_device *vdpa_dev, u8 status)
> !(status_old & VIRTIO_CONFIG_S_DRIVER_OK)) {
> ret = ifcvf_request_irq(vf);
> if (ret) {
> - status = ifcvf_get_status(vf);
> - status |= VIRTIO_CONFIG_S_FAILED;
> - ifcvf_set_status(vf, status);
> + IFCVF_ERR(vf->pdev, "failed to request irq with error %d\n", ret);
> return;
> }
> }
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-04-26 5:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 20:48 [PATCH 0/5] vDPA/ifcvf: implement immediate initialization mechanism Zhu Lingshan
2023-03-31 20:48 ` [PATCH 1/5] virt queue ops take immediate actions Zhu Lingshan
2023-04-26 3:39 ` Jason Wang
2023-04-27 8:02 ` Zhu, Lingshan
2023-03-31 20:48 ` [PATCH 2/5] get_driver_features from virito registers Zhu Lingshan
2023-04-24 4:50 ` Michael S. Tsirkin
2023-04-24 7:24 ` Zhu, Lingshan
2023-04-26 4:02 ` Jason Wang
2023-04-27 8:28 ` Zhu, Lingshan
2023-03-31 20:48 ` [PATCH 3/5] retire ifcvf_start_datapath and ifcvf_add_status Zhu Lingshan
2023-04-26 4:04 ` Jason Wang
2023-03-31 20:48 ` [PATCH 4/5] synchronize irqs in the reset routine Zhu Lingshan
2023-04-26 5:06 ` Jason Wang
2023-04-27 9:07 ` Zhu, Lingshan
2023-03-31 20:48 ` [PATCH 5/5] a vendor driver should not set _CONFIG_S_FAILED Zhu Lingshan
2023-04-26 5:10 ` Jason Wang [this message]
2023-04-03 5:28 ` [PATCH 0/5] vDPA/ifcvf: implement immediate initialization mechanism Jason Wang
2023-04-03 10:10 ` Zhu, Lingshan
2023-04-20 9:17 ` Zhu, Lingshan
2023-04-24 3:50 ` Jason Wang
2023-04-24 4:52 ` Michael S. Tsirkin
2023-04-24 5:20 ` Jason Wang
2023-04-24 9:53 ` Michael S. Tsirkin
2023-04-24 4:51 ` Michael S. Tsirkin
2023-04-24 7:25 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c130a02f-08d1-314c-859d-5a62ff01fb0f@redhat.com \
--to=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox