* [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan
@ 2022-06-07 6:49 Dan Carpenter
2022-06-07 6:50 ` [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan() Dan Carpenter
2022-06-08 0:21 ` [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Si-Wei Liu
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-06-07 6:49 UTC (permalink / raw)
To: Michael S. Tsirkin, Eli Cohen; +Cc: kernel-janitors, virtualization
Return success if we were able to delete a vlan. The current code
always returns failure.
Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
From review. (Not tested).
drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index b7a955479156..c964f4161d7f 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1814,6 +1814,7 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
id = mlx5vdpa16_to_cpu(mvdev, vlan);
mac_vlan_del(ndev, ndev->config.mac, id, true);
+ status = VIRTIO_NET_OK;
break;
default:
break;
--
2.35.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan()
2022-06-07 6:49 [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Dan Carpenter
@ 2022-06-07 6:50 ` Dan Carpenter
2022-06-08 0:21 ` Si-Wei Liu
2022-06-08 0:21 ` [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Si-Wei Liu
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2022-06-07 6:50 UTC (permalink / raw)
To: Michael S. Tsirkin, Eli Cohen; +Cc: kernel-janitors, virtualization
These lines were supposed to be indented.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index c964f4161d7f..83607b7488f1 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1817,10 +1817,10 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
status = VIRTIO_NET_OK;
break;
default:
- break;
-}
+ break;
+ }
-return status;
+ return status;
}
static void mlx5_cvq_kick_handler(struct work_struct *work)
--
2.35.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan()
2022-06-07 6:50 ` [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan() Dan Carpenter
@ 2022-06-08 0:21 ` Si-Wei Liu
0 siblings, 0 replies; 4+ messages in thread
From: Si-Wei Liu @ 2022-06-08 0:21 UTC (permalink / raw)
To: Dan Carpenter, Michael S. Tsirkin, Eli Cohen
Cc: kernel-janitors, virtualization
On 6/6/2022 11:50 PM, Dan Carpenter wrote:
> These lines were supposed to be indented.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index c964f4161d7f..83607b7488f1 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1817,10 +1817,10 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
> status = VIRTIO_NET_OK;
> break;
> default:
> - break;
> -}
> + break;
> + }
>
> -return status;
> + return status;
> }
>
> static void mlx5_cvq_kick_handler(struct work_struct *work)
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan
2022-06-07 6:49 [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Dan Carpenter
2022-06-07 6:50 ` [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan() Dan Carpenter
@ 2022-06-08 0:21 ` Si-Wei Liu
1 sibling, 0 replies; 4+ messages in thread
From: Si-Wei Liu @ 2022-06-08 0:21 UTC (permalink / raw)
To: Dan Carpenter, Michael S. Tsirkin, Eli Cohen
Cc: kernel-janitors, virtualization
On 6/6/2022 11:49 PM, Dan Carpenter wrote:
> Return success if we were able to delete a vlan. The current code
> always returns failure.
>
> Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> From review. (Not tested).
>
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index b7a955479156..c964f4161d7f 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1814,6 +1814,7 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
>
> id = mlx5vdpa16_to_cpu(mvdev, vlan);
> mac_vlan_del(ndev, ndev->config.mac, id, true);
> + status = VIRTIO_NET_OK;
> break;
> default:
> break;
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-08 0:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-07 6:49 [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Dan Carpenter
2022-06-07 6:50 ` [PATCH 2/2] vdpa/mlx5: clean up indenting in handle_ctrl_vlan() Dan Carpenter
2022-06-08 0:21 ` Si-Wei Liu
2022-06-08 0:21 ` [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan Si-Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).