From: Markus Elfring <Markus.Elfring@web.de>
To: Xiong Weimin <xiongweimin@kylinos.cn>,
virtualization@lists.linux.dev,
Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH] vdpa: solidrun: Free IRQs after request failure
Date: Tue, 4 Aug 2026 18:54:24 +0200 [thread overview]
Message-ID: <c592a594-b2cf-46c5-98d0-2935b9a5ebab@web.de> (raw)
In-Reply-To: <20260804092617.1344317-1-xiongweimin@kylinos.cn>
> Unwind any IRQs already requested by snet_request_irqs() before returning
> an error so a later retry starts from a clean state.
How good does a proposed snet_free_irqs(snet) call fit to previous devm_request_irq() calls?
I suggest to avoid duplicate exception handling code for affected cases.
Regards,
Markus
next prev parent reply other threads:[~2026-08-04 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 9:26 [PATCH] vdpa: solidrun: Free IRQs after request failure Xiong Weimin
2026-08-04 16:54 ` Markus Elfring [this message]
2026-08-05 1:39 ` Xiong Weimin
2026-08-04 21:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c592a594-b2cf-46c5-98d0-2935b9a5ebab@web.de \
--to=markus.elfring@web.de \
--cc=alvaro.karsz@solid-run.com \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xiongweimin@kylinos.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox