From: Dave Hansen <dave.hansen@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, x86@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
linux-pci@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Alexey Makhalov <amakhalov@vmware.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Darren Hart <dvhart@infradead.org>,
linux-trace-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
platform-driver-x86@vger.kernel.org,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH 10/20] x86: xen: add missing prototypes
Date: Thu, 18 May 2023 10:28:58 -0700 [thread overview]
Message-ID: <cabdd839-71d5-aabb-aee6-d37ebcabf2ab@intel.com> (raw)
In-Reply-To: <20230516193549.544673-11-arnd@kernel.org>
On 5/16/23 12:35, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> arch/x86/xen/enlighten_pv.c:1233:34: error: no previous prototype for 'xen_start_kernel' [-Werror=missing-prototypes]
> arch/x86/xen/irq.c:22:14: error: no previous prototype for 'xen_force_evtchn_callback' [-Werror=missing-prototypes]
> arch/x86/xen/mmu_pv.c:358:20: error: no previous prototype for 'xen_pte_val' [-Werror=missing-prototypes]
> arch/x86/xen/mmu_pv.c:366:20: error: no previous prototype for 'xen_pgd_val' [-Werror=missing-prototypes]
What's the deal with this one?
The patch is doing a bunch functions on top of the ones from the commit
message. Were you just showing a snippet of what the actual set of
warnings is?
Also, fwiw, it would be nice to have actual words in the changelog, even
for these maddeningly repetitive series. Even something like:
Xen has a bunch of these because of how the paravirt code uses
inline assembly.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-05-18 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516193549.544673-1-arnd@kernel.org>
[not found] ` <20230516193549.544673-2-arnd@kernel.org>
2023-05-16 21:44 ` [PATCH 01/20] x86: move prepare_ftrace_return prototype to header Steven Rostedt
[not found] ` <20230516193549.544673-11-arnd@kernel.org>
2023-05-18 17:28 ` Dave Hansen [this message]
2023-05-19 11:04 ` [PATCH 10/20] x86: xen: add missing prototypes Arnd Bergmann
2023-05-18 17:31 ` [PATCH 00/20] x86: address -Wmissing-prototype warnings Dave Hansen
2023-05-18 21:56 ` Dave Hansen
2023-05-19 9:51 ` Andy Shevchenko
2023-05-19 12:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cabdd839-71d5-aabb-aee6-d37ebcabf2ab@intel.com \
--to=dave.hansen@intel.com \
--cc=amakhalov@vmware.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox