[PATCH 00/11] Replace printk_rateilimit() with printk_ratelimited()

[PATCH 00/11] Replace printk_rateilimit() with printk_ratelimited()

[Manuel Zerpies]

Hi,

since the printk_ratelimit() function shouldn't be used anymore, I replaced it
in a few files with printk_ratelimited().

If you wish some more patches I can send more in.

Greets,
Manu

Manuel Zerpies (11):
  drivers/ide: use printk_ratelimited() instead of printk_ratelimit()
  drivers/tty: use printk_ratelimited() instead of printk_ratelimit()
  net/can: use printk_ratelimited() instead of printk_ratelimit()
  net/rds: use prink_ratelimited() instead of printk_ratelimit()
  RDMA/hw/cxgb4: use printk_ratelimited() instead of printk_ratelimit()
  drivers/net: use printk_ratelimited() instead of printk_ratelimit()
  drivers/usb/atm: use printk_ratelimited() instead of
    printk_ratelimit()
  [SCSI] tcm_fc: use printk_ratelimited() instead of printk_ratelimit()
  xen/xenbus: use printk_ratelimited() instead of printk_ratelimit()
  wusb: use printk_ratelimited() instead of printk_ratelimit()
  usb/class: use printk_ratelimited() instead of printk_ratelimit()

 drivers/ide/ide-atapi.c                |    4 ++--
 drivers/infiniband/hw/cxgb4/resource.c |    9 +++++----
 drivers/net/sc92031.c                  |   16 ++++++----------
 drivers/target/tcm_fc/tfc_io.c         |    4 ++--
 drivers/tty/moxa.c                     |    5 +++--
 drivers/tty/mxser.c                    |    4 ++--
 drivers/tty/tty_io.c                   |    4 ++--
 drivers/usb/atm/usbatm.c               |    4 ++--
 drivers/usb/class/usblp.c              |    7 +++----
 drivers/usb/wusbcore/wa-xfer.c         |    7 +++----
 drivers/xen/xenbus/xenbus_xs.c         |    4 ++--
 net/can/af_can.c                       |    5 +++--
 net/rds/bind.c                         |    4 ++--
 net/rds/ib_cm.c                        |    6 +++---
 net/rds/ib_send.c                      |    4 ++--
 net/rds/iw_cm.c                        |    9 ++++-----
 net/rds/iw_rdma.c                      |    9 +++++----
 net/rds/iw_send.c                      |    4 ++--
 net/rds/send.c                         |    7 +++----
 19 files changed, 56 insertions(+), 60 deletions(-)

-- 
1.7.4.1

[PATCH 09/11] xen/xenbus: use printk_ratelimited() instead of printk_ratelimit()

[Manuel Zerpies]

Since printk_ratelimit() shouldn't be used anymore (see comment in
include/linux/printk.h), replace it with printk_ratelimited()

Signed-off-by: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
---
 drivers/xen/xenbus/xenbus_xs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
index 5534690..4055858 100644
--- a/drivers/xen/xenbus/xenbus_xs.c
+++ b/drivers/xen/xenbus/xenbus_xs.c
@@ -44,6 +44,7 @@
 #include <linux/rwsem.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/ratelimit.h>
 #include <xen/xenbus.h>
 #include "xenbus_comms.h"
 
@@ -270,8 +271,7 @@ static void *xs_talkv(struct xenbus_transaction t,
 	}
 
 	if (msg.type != type) {
-		if (printk_ratelimit())
-			printk(KERN_WARNING
+		`printk_ratelimited(KERN_WARNING
 			       "XENBUS unexpected type [%d], expected [%d]\n",
 			       msg.type, type);
 		kfree(ret);
-- 
1.7.4.1

Re: [PATCH 09/11] xen/xenbus: use printk_ratelimited() instead of printk_ratelimit()

[Jeremy Fitzhardinge]

On 06/16/2011 05:14 AM, Manuel Zerpies wrote:
> Since printk_ratelimit() shouldn't be used anymore (see comment in
> include/linux/printk.h), replace it with printk_ratelimited()
>
Looks OK to me, but please fix the indentation of the rest of the
statement to match.

Thanks,
    J

> Signed-off-by: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
> ---
>  drivers/xen/xenbus/xenbus_xs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
> index 5534690..4055858 100644
> --- a/drivers/xen/xenbus/xenbus_xs.c
> +++ b/drivers/xen/xenbus/xenbus_xs.c
> @@ -44,6 +44,7 @@
>  #include <linux/rwsem.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> +#include <linux/ratelimit.h>
>  #include <xen/xenbus.h>
>  #include "xenbus_comms.h"
>  
> @@ -270,8 +271,7 @@ static void *xs_talkv(struct xenbus_transaction t,
>  	}
>  
>  	if (msg.type != type) {
> -		if (printk_ratelimit())
> -			printk(KERN_WARNING
> +		`printk_ratelimited(KERN_WARNING
>  			       "XENBUS unexpected type [%d], expected [%d]\n",
>  			       msg.type, type);
>  		kfree(ret);

Re: [PATCH 09/11] xen/xenbus: use printk_ratelimited() instead of printk_ratelimit()

[Joe Perches]

On Thu, 2011-06-16 at 14:00 -0700, Jeremy Fitzhardinge wrote:
> On 06/16/2011 05:14 AM, Manuel Zerpies wrote:
> > Since printk_ratelimit() shouldn't be used anymore (see comment in
> > include/linux/printk.h), replace it with printk_ratelimited()
> Looks OK to me, but please fix the indentation of the rest of the
> statement to match.
[]
> > diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
[]
> > @@ -270,8 +271,7 @@ static void *xs_talkv(struct xenbus_transaction t,
> >  	}
> >  
> >  	if (msg.type != type) {
> > -		if (printk_ratelimit())
> > -			printk(KERN_WARNING
> > +		`printk_ratelimited(KERN_WARNING

Appears that it's not compile tested?
A stray "`" got put before printk_ratelimited()