virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>
Subject: [PATCH v2 00/11] virtio: console: fixes for port unplug
Date: Fri, 19 Jul 2013 16:51:53 +0530	[thread overview]
Message-ID: <cover.1374232738.git.amit.shah@redhat.com> (raw)

Hello,

This series fixes a few bugs and races with port unplug and the
various file operations: read(), write(), close() and poll().

There still might be more races lurking, but testing this series looks
good to at least solve the easily-triggerable ones.  I've run the
virtio-serial testsuite and a few open/close/unplug tests, and haven't
seen any badness.

I've marked these patches for stable@ as well.  I went over the list
twice to check if really each one should go to stable, and to me it
looks like all are stable candidates.

v2
 * add patch 11: Jason found a use-after-free in port unplug
 * patch 7 introduced a regression where the wake_up_interruptible was
   done before guest_connected and host_connected were set to false

Please review and apply,

Amit Shah (11):
  virtio: console: fix race with port unplug and open/close
  virtio: console: fix race in port_fops_open() and port unplug
  virtio: console: clean up port data immediately at time of unplug
  virtio: console: return -ENODEV on all read operations after unplug
  virtio: console: update private_data in struct file only on successful
    open
  virtio: console: fix race in port_fops_poll() and port unplug
  virtio: console: fix raising SIGIO after port unplug
  virtio: console: add locks around buffer removal in port unplug path
  virtio: console: add locking in port unplug path
  virtio: console: fix locking around send_sigio_to_port()
  virtio: console: prevent use-after-free of port name in port unplug

 drivers/char/virtio_console.c | 70 +++++++++++++++++++++++++++----------------
 1 file changed, 45 insertions(+), 25 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-07-19 11:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 11:21 Amit Shah [this message]
2013-07-19 11:21 ` [PATCH v2 01/11] virtio: console: fix race with port unplug and open/close Amit Shah
2013-07-19 11:21 ` [PATCH v2 02/11] virtio: console: fix race in port_fops_open() and port unplug Amit Shah
2013-07-19 11:21 ` [PATCH v2 03/11] virtio: console: clean up port data immediately at time of unplug Amit Shah
2013-07-19 11:21 ` [PATCH v2 04/11] virtio: console: return -ENODEV on all read operations after unplug Amit Shah
2013-07-19 11:21 ` [PATCH v2 05/11] virtio: console: update private_data in struct file only on successful open Amit Shah
2013-07-19 11:21 ` [PATCH v2 06/11] virtio: console: fix race in port_fops_poll() and port unplug Amit Shah
2013-07-19 11:22 ` [PATCH v2 07/11] virtio: console: fix raising SIGIO after " Amit Shah
2013-07-19 11:22 ` [PATCH v2 08/11] virtio: console: add locks around buffer removal in port unplug path Amit Shah
2013-07-19 11:22 ` [PATCH v2 09/11] virtio: console: add locking " Amit Shah
2013-07-19 11:22 ` [PATCH v2 10/11] virtio: console: fix locking around send_sigio_to_port() Amit Shah
2013-07-19 11:22 ` [PATCH v2 11/11] virtio: console: prevent use-after-free of port name in port unplug Amit Shah
2013-07-22  6:30 ` [PATCH v2 00/11] virtio: console: fixes for " Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1374232738.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).