From: Amit Shah <amit.shah@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jason@lakedaemon.net, keescook@chromium.org,
Virtualization List <virtualization@lists.linux-foundation.org>,
Amit Shah <amit.shah@redhat.com>,
herbert@gondor.apana.org.au
Subject: [PATCH v2 0/2] hwrng, virtio-rng: init-time fixes
Date: Sat, 5 Jul 2014 11:04:51 +0530 [thread overview]
Message-ID: <cover.1404538109.git.amit.shah@redhat.com> (raw)
v2:
- this now separates both the patches; the virtio-rng fix is self-contained
- re-work hwrng core to fetch randomness at device init time if
->init() is registered by the device, instead of not calling it at all.
- virtio-rng: introduce a probe_done bool to ensure we don't ask host
for data before successful probe
Hi,
When booting a recent kernel under KVM with the virtio-rng device
enabled, the boot process was stalling. Bisect pointed to a commit
made during the 3.15 window to fetch randomness from newly-registered
devices in the hwrng core. The details are in the patches.
Turns out there were two bugs: the initial randomness was being
fetched w/o the device being initialized in cases where the init
callback was registered and the device wasn't the first device being
added to the hwrng core. The second bug is virtio can't communicate
with the host without the device probe is successfully completed.
Please review and apply if appropriate,
Amit Shah (2):
hwrng: fetch randomness only after device init
virtio: rng: ensure reads happen after successful probe
drivers/char/hw_random/core.c | 37 +++++++++++++++++++++++++++++++------
drivers/char/hw_random/virtio-rng.c | 10 ++++++++++
2 files changed, 41 insertions(+), 6 deletions(-)
--
1.9.3
next reply other threads:[~2014-07-05 5:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 5:34 Amit Shah [this message]
2014-07-05 5:34 ` [PATCH v2 1/2] hwrng: fetch randomness only after device init Amit Shah
2014-07-07 4:41 ` Kees Cook
[not found] ` <CAGXu5j+j1LUv_rRpf=03nRfu=Sek5O8TUs8R066JvfbUgT9ZQQ@mail.gmail.com>
2014-07-07 5:53 ` Amit Shah
2014-07-07 6:04 ` Amit Shah
2014-07-07 6:39 ` Amit Shah
2014-07-09 11:53 ` Jason Cooper
2014-07-09 13:08 ` Amit Shah
2014-07-09 13:17 ` Jason Cooper
2014-07-09 13:25 ` Amit Shah
2014-07-09 16:07 ` [RFC PATCH] hwrng: sysfs entry rng_seed_kernel, was: "Re: [PATCH v2 1/2] hwrng: fetch randomness only after device init" Jason Cooper
2014-07-11 13:26 ` Amit Shah
2014-07-11 15:44 ` Jason Cooper
2014-07-14 21:50 ` Kees Cook
2014-07-05 5:34 ` [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe Amit Shah
2014-07-07 4:38 ` Kees Cook
2014-07-07 5:51 ` Amit Shah
2014-07-07 6:09 ` Kees Cook
2014-07-07 6:34 ` Amit Shah
2014-07-09 12:08 ` Jason Cooper
2014-07-09 13:15 ` Amit Shah
2014-07-09 16:18 ` Jason Cooper
2014-07-10 8:45 ` Herbert Xu
2014-07-10 8:52 ` Amit Shah
[not found] ` <20140710084514.GA15418@gondor.apana.org.au>
2014-07-10 9:53 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1404538109.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).