Linux virtualization list
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-s390@vger.kernel.org,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linux390@de.ibm.com, Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH v3 0/5] virtio: Clean up scatterlists and use the DMA API
Date: Thu, 28 Aug 2014 16:51:39 -0700	[thread overview]
Message-ID: <cover.1409269667.git.luto@amacapital.net> (raw)

This fixes virtio on Xen guests as well as on any other platform
that uses virtio_pci on which physical addresses don't match bus
addresses.

This can be tested with:

    virtme-run --xen xen --kimg arch/x86/boot/bzImage --console

using virtme from here:

    https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git

Without these patches, the guest hangs forever.  With these patches,
everything works.

This should be safe on all platforms that I'm aware of.  That
doesn't mean that there isn't anything that I missed.

Patches 4 and 5 are optional cleanups.  I strongly encourage the
virtio maintainers to apply patch 4, since it should be a very minor
speedup as well as a cleanup, and patch 4 is critical fix if patch 5
is applied.

Patch 5 is last for ease of reversion in case it causes problems.
It is not necessary for DMA mappings to work, and it does not fix
any bugs that I know of.  It's just a cleanup.

Thanks to everyone for putting up with the development of this
series.  Hopefully it'll be the end of DMA issues in virtio. :)

Changes from v2:
 - Reordered patches.
 - Fixed a virtio_net OOPS.

Changes from v1:
 - Using the DMA API is optional now.  It would be nice to improve the
   DMA API to the point that it could be used unconditionally, but s390
   proves that we're not there yet.
 - Includes patch 4, which fixes DMA debugging warnings from virtio_net.

Andy Lutomirski (5):
  virtio_ring: Support DMA APIs if requested
  virtio_pci: Use the DMA API for virtqueues
  virtio_net: Stop doing DMA from the stack
  virtio_net: Don't set the end flag on reusable sg entries
  virtio_ring: Remove sg_next indirection

 drivers/lguest/lguest_device.c         |   3 +-
 drivers/misc/mic/card/mic_virtio.c     |   2 +-
 drivers/net/virtio_net.c               |  59 ++++++---
 drivers/remoteproc/remoteproc_virtio.c |   4 +-
 drivers/s390/kvm/kvm_virtio.c          |   2 +-
 drivers/s390/kvm/virtio_ccw.c          |   4 +-
 drivers/virtio/virtio_mmio.c           |   5 +-
 drivers/virtio/virtio_pci.c            |  35 ++++--
 drivers/virtio/virtio_ring.c           | 219 ++++++++++++++++++++++++++-------
 include/linux/virtio_ring.h            |   1 +
 tools/virtio/linux/virtio.h            |   1 +
 tools/virtio/virtio_test.c             |   2 +-
 tools/virtio/vringh_test.c             |   3 +-
 13 files changed, 256 insertions(+), 84 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-08-28 23:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 23:51 Andy Lutomirski [this message]
2014-08-28 23:51 ` [PATCH v3 1/5] virtio_ring: Support DMA APIs if requested Andy Lutomirski
2014-08-28 23:51 ` [PATCH v3 2/5] virtio_pci: Use the DMA API for virtqueues Andy Lutomirski
2014-08-28 23:51 ` [PATCH v3 3/5] virtio_net: Stop doing DMA from the stack Andy Lutomirski
2014-08-28 23:51 ` [PATCH v3 4/5] virtio_net: Don't set the end flag on reusable sg entries Andy Lutomirski
2014-08-28 23:51 ` [PATCH v3 5/5] virtio_ring: Remove sg_next indirection Andy Lutomirski
2014-08-29  7:43 ` [PATCH v3 0/5] virtio: Clean up scatterlists and use the DMA API Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1409269667.git.luto@amacapital.net \
    --to=luto@amacapital.net \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox