From: Amit Shah <amit.shah@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jason@lakedaemon.net, keescook@chromium.org,
Virtualization List <virtualization@lists.linux-foundation.org>,
Amit Shah <amit.shah@redhat.com>,
herbert@gondor.apana.org.au
Subject: [RFC PATCH 2/3] virtio: rng: only accept delayed early randomness requests
Date: Mon, 14 Jul 2014 10:05:20 +0530 [thread overview]
Message-ID: <d2e8c74866e002fe8c9ec62c00dc70a75328ecf9.1405277045.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1405277045.git.amit.shah@redhat.com>
In-Reply-To: <cover.1405277045.git.amit.shah@redhat.com>
hw_random core can ask for initial randomness after a slight delay after
probe() finishes, and we can contribute to system randomness at that
point. Tell the hw_random core by setting the HWRNG_DELAY_READ_AT_INIT
flag.
CC: Kees Cook <keescook@chromium.org>
CC: Jason Cooper <jason@lakedaemon.net>
CC: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/hw_random/virtio-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index d8ffebd..f53f1e8 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -123,6 +123,7 @@ static int probe_common(struct virtio_device *vdev)
.cleanup = virtio_cleanup,
.priv = (unsigned long)vi,
.name = vi->name,
+ .flags = HWRNG_DELAY_READ_AT_INIT,
};
vdev->priv = vi;
--
1.9.3
next prev parent reply other threads:[~2014-07-14 4:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 4:35 [RFC PATCH 0/3] hw_random: support for delayed init randomness requests Amit Shah
2014-07-14 4:35 ` [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay Amit Shah
2014-07-14 12:37 ` Jason Cooper
2014-07-14 12:42 ` Amit Shah
2014-07-18 8:56 ` Amit Shah
2014-07-18 9:14 ` Herbert Xu
2014-07-18 9:27 ` Amit Shah
2014-07-14 4:35 ` Amit Shah [this message]
2014-07-14 4:35 ` [RFC PATCH 3/3] Revert "virtio: rng: ensure reads happen after successful probe" Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2e8c74866e002fe8c9ec62c00dc70a75328ecf9.1405277045.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).