From: Vishwanath Seshagiri <vishs@meta.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>, "David Wei" <dw@davidwei.uk>,
"Matteo Croce" <technoboy85@gmail.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next v5 2/2] virtio_net: add page_pool support for buffer allocation
Date: Fri, 6 Feb 2026 21:25:25 -0800 [thread overview]
Message-ID: <e4a76ce5-9675-488f-a8f4-0f0541024d00@meta.com> (raw)
In-Reply-To: <20260206204140.56d85273@kernel.org>
On 2/6/26 8:41 PM, Jakub Kicinski wrote:
> On Thu, 5 Feb 2026 16:27:15 -0800 Vishwanath Seshagiri wrote:
>> + page = page_pool_alloc_frag(rq->page_pool, &offset, len + room, gfp);
>> + if (unlikely(!page))
>> return -ENOMEM;
>>
>> + buf = page_address(page) + offset;
>
> Please take a look at page_pool_alloc_va()
>
> I mean all the way down until you reach page_pool_alloc_netmem()
> and realize the helper you're adding in patch 1 is a solved problem
I apologize for adding patch 1. I will use page_pool_alloc_va and send
v6 with only patch 2.
prev parent reply other threads:[~2026-02-07 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 0:27 [PATCH net-next v5 0/2] virtio_net: add page_pool support Vishwanath Seshagiri
2026-02-06 0:27 ` [PATCH net-next v5 1/2] page_pool: add page_pool_frag_offset_add() helper Vishwanath Seshagiri
2026-02-06 0:27 ` [PATCH net-next v5 2/2] virtio_net: add page_pool support for buffer allocation Vishwanath Seshagiri
2026-02-07 4:41 ` Jakub Kicinski
2026-02-07 5:25 ` Vishwanath Seshagiri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a76ce5-9675-488f-a8f4-0f0541024d00@meta.com \
--to=vishs@meta.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jasowang@redhat.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=technoboy85@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox