From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5E42AD13; Wed, 17 Dec 2025 00:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765930180; cv=none; b=jedHUxMAD7ax0eIvM+iXvpDx6O2fCFTF2+mIWKwxFIs7niOXcgFAtisWrriQJyAg/4Svg3OyZSHb/gaStyym3r/HXhpF25tNFPK8HVLoKgoinZmJ5Lr3pmH+PRiua9iLuAUz2Cmh5PojC2tBaey3rvlFU8ty/nfCkCCjZACN9+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765930180; c=relaxed/simple; bh=aZR9wSyi+zJsIHvJriUMfLQABKctzyX5fXgs8GO8n4U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G7MdgsFLDZ9Hm5VV6+gzHsraChI9946nDUcENdsyLiWvVKJyefsFIwr0rkr+PXQgFeMDVr1kbua0B4nwO63X6rU+iYP4m/ybPhiA4ndfkpP4iE1nYbG4j0Uwm1klMzVLx8wIjY4JW4BfFI6ZJ8YjnEnwwOs9oTpEr+q0M7WX1ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aNI6UMU2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aNI6UMU2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CCD5C4CEF1; Wed, 17 Dec 2025 00:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765930180; bh=aZR9wSyi+zJsIHvJriUMfLQABKctzyX5fXgs8GO8n4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aNI6UMU2+C9auZatxSgLKTA4RJ8Tc8yGSyXopvdXSVgldtvnHa6Ken0sARx4y/+7E vTZ50xFdj1tMQ//XOkLKgN4vvA0M8q5a90sGtX+/o49rR0WOpEAoagq+nWaDWWFzC2 A+ckdLIbUqlzEVk/gc+gkcqWB01O7qoty08Du5crzhaVhPQGYiiWrUEyDGfCxakcBV 7/Vhq9JR056MU/kxoCZ6IQJrLttskLj7lv7AonqdrTHCXfFEdheN1OlszL9XqoU/8Y GI4TxOTez3ZYyi/BtyoTEdpc9tG9UwXITx9UVU576wwFjXer281n4kx9KhSKtCsvy+ odgHmbJMW4r/A== Message-ID: Date: Wed, 17 Dec 2025 01:09:18 +0100 Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/14] mm: Describe @flags parameter in memalloc_flags_save() To: Bagas Sanjaya , Linux Kernel Mailing List , Linux AMDGPU , Linux DRI Development , Linux Filesystems Development , Linux Media , linaro-mm-sig@lists.linaro.org, kasan-dev@googlegroups.com, Linux Virtualization , Linux Memory Management List , Linux Network Bridge , Linux Networking Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthew Brost , Danilo Krummrich , Philipp Stanner , Alexander Viro , Christian Brauner , Jan Kara , Sumit Semwal , Alexander Potapenko , Marco Elver , Dmitry Vyukov , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Uladzislau Rezki , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Taimur Hassan , Wayne Lin , Alex Hung , Aurabindo Pillai , Dillon Varone , George Shen , Aric Cyr , Cruise Hung , Mario Limonciello , Sunil Khatri , Dominik Kaszewski , Peter Zijlstra , Lorenzo Stoakes , Max Kellermann , "Nysal Jan K.A." , Ryan Roberts , Alexey Skidanov , Vlastimil Babka , Kent Overstreet , Vitaly Wool , Harry Yoo , Mateusz Guzik , NeilBrown , Amir Goldstein , Jeff Layton , Ivan Lipski , Tao Zhou , YiPeng Chai , Hawking Zhang , Lyude Paul , Daniel Almeida , Luben Tuikov , Matthew Auld , Roopa Prabhu , Mao Zhu , Shaomin Deng , Charles Han , Jilin Yuan , Swaraj Gaikwad , George Anthony Vernon References: <20251215113903.46555-1-bagasdotme@gmail.com> <20251215113903.46555-3-bagasdotme@gmail.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251215113903.46555-3-bagasdotme@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/25 12:38, Bagas Sanjaya wrote: > Sphinx reports kernel-doc warning: > > WARNING: ./include/linux/sched/mm.h:332 function parameter 'flags' not described in 'memalloc_flags_save' > > Describe @flags to fix it. > > Fixes: 3f6d5e6a468d02 ("mm: introduce memalloc_flags_{save,restore}") > Signed-off-by: Bagas Sanjaya > --- > include/linux/sched/mm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index 0e1d73955fa511..95d0040df58413 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -325,6 +325,7 @@ static inline void might_alloc(gfp_t gfp_mask) > > /** > * memalloc_flags_save - Add a PF_* flag to current->flags, save old value > + * @flags: Flags to add. > * > * This allows PF_* flags to be conveniently added, irrespective of current > * value, and then the old version restored with memalloc_flags_restore(). Acked-by: David Hildenbrand (Red Hat) -- Cheers David