From: David Hildenbrand <david@redhat.com>
To: Zi Yan <ziy@nvidia.com>, linux-mm@kvack.org
Cc: Mel Gorman <mgorman@techsingularity.net>,
Michael Ellerman <mpe@ellerman.id.au>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Eric Ren <renzhengeek@gmail.com>,
virtualization@lists.linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
Vlastimil Babka <vbabka@suse.cz>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [RFC PATCH v3 5/8] mm: page_isolation: check specified range for unmovable pages during isolation.
Date: Fri, 14 Jan 2022 14:38:30 +0100 [thread overview]
Message-ID: <ead90b32-da2b-4d66-f103-6fbec0937e93@redhat.com> (raw)
In-Reply-To: <20220105214756.91065-6-zi.yan@sent.com>
On 05.01.22 22:47, Zi Yan wrote:
> From: Zi Yan <ziy@nvidia.com>
>
> Enable set_migratetype_isolate() to check specified sub-range for
> unmovable pages during isolation. Page isolation is done
> at max(MAX_ORDER_NR_PAEGS, pageblock_nr_pages) granularity, but not all
> pages within that granularity are intended to be isolated. For example,
> alloc_contig_range(), which uses page isolation, allows ranges without
> alignment. This commit makes unmovable page check only look for
> interesting pages, so that page isolation can succeed for any
> non-overlapping ranges.
Are you handling if we start checking in the middle of a compound page
and actually have to lookup the head to figure out if movable or not?
>
> has_unmovable_pages() is moved to mm/page_isolation.c since it is only
> used by page isolation.
Please move that into a separate patch upfront, makes this patch much
easier to review.
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-14 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220105214756.91065-1-zi.yan@sent.com>
[not found] ` <20220105214756.91065-2-zi.yan@sent.com>
2022-01-12 10:54 ` [RFC PATCH v3 1/8] mm: page_alloc: avoid merging non-fallbackable pageblocks with others David Hildenbrand
[not found] ` <YeAO0vtyjWWMRliF@kernel.org>
2022-01-13 12:28 ` David Hildenbrand
[not found] ` <20220105214756.91065-3-zi.yan@sent.com>
2022-01-12 11:01 ` [RFC PATCH v3 2/8] mm: compaction: handle non-lru compound pages properly in isolate_migratepages_block() David Hildenbrand
[not found] ` <20220105214756.91065-4-zi.yan@sent.com>
2022-01-12 11:04 ` [RFC PATCH v3 3/8] mm: migrate: allocate the right size of non hugetlb or THP compound pages David Hildenbrand
[not found] ` <15E26B9B-8AE2-4916-94E7-D0BBB2491B1B@nvidia.com>
2022-01-13 15:50 ` David Hildenbrand
[not found] ` <20220105214756.91065-6-zi.yan@sent.com>
2022-01-14 13:38 ` David Hildenbrand [this message]
[not found] ` <20220105214756.91065-8-zi.yan@sent.com>
2022-01-14 13:44 ` [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead90b32-da2b-4d66-f103-6fbec0937e93@redhat.com \
--to=david@redhat.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mpe@ellerman.id.au \
--cc=renzhengeek@gmail.com \
--cc=robin.murphy@arm.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).