From: Jens Axboe <axboe@kernel.dk>
To: Alex Deucher <alexdeucher@gmail.com>, Yang Rong <yangrong@vivo.com>
Cc: "Max Tseng" <Max.Tseng@amd.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:VIRTIO CORE AND NET DRIVERS"
<virtualization@lists.linux-foundation.org>,
"Eric Dumazet" <edumazet@google.com>, "Jun Lei" <Jun.Lei@amd.com>,
"Josip Pavic" <Josip.Pavic@amd.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"David Airlie" <airlied@gmail.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"open list:AMD DISPLAY CORE" <amd-gfx@lists.freedesktop.org>,
"open list:IO_URING" <io-uring@vger.kernel.org>,
"Alvin Lee" <Alvin.Lee2@amd.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Harry Wentland" <harry.wentland@amd.com>,
opensource.kernel@vivo.com, "Leo Li" <sunpeng.li@amd.com>,
"Cruise Hung" <cruise.hung@amd.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
luhongfei@vivo.com, "David S. Miller" <davem@davemloft.net>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pavel Begunkov" <asml.silence@gmail.com>
Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring
Date: Thu, 6 Jul 2023 08:03:51 -0600 [thread overview]
Message-ID: <ec9b55b5-c64c-3ea4-9f39-128cd2e0a8ac@kernel.dk> (raw)
In-Reply-To: <CADnq5_MSkJf=-QMPYNQp03=6mbb+OEHnPFW0=WKiS0VMc6ricQ@mail.gmail.com>
On 7/6/23 7:58?AM, Alex Deucher wrote:
> On Thu, Jul 6, 2023 at 3:37?AM Yang Rong <yangrong@vivo.com> wrote:
>>
>> The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings.
>> Specifically, the opportunities for max() and min() were utilized to address the warnings.
>
> Please split this into 3 patches, one for each component.
Don't bother with the io_uring one, code is far more readable as-is.
--
Jens Axboe
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-07-06 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230706021102.2066-1-yangrong@vivo.com>
2023-07-06 13:58 ` [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Alex Deucher
2023-07-06 14:03 ` Jens Axboe [this message]
2023-07-06 14:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9b55b5-c64c-3ea4-9f39-128cd2e0a8ac@kernel.dk \
--to=axboe@kernel.dk \
--cc=Alvin.Lee2@amd.com \
--cc=Josip.Pavic@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Max.Tseng@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asml.silence@gmail.com \
--cc=christian.koenig@amd.com \
--cc=cruise.hung@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=harry.wentland@amd.com \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=qingqing.zhuo@amd.com \
--cc=sunpeng.li@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yangrong@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).