From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Amit Shah <amit.shah@redhat.com>,
Virtualization List <virtualization@lists.linux-foundation.org>
Subject: [PATCH 2/4] virtio: console: Annotate virtcons_remove with __devexit_p
Date: Thu, 26 Aug 2010 10:34:06 +0530 [thread overview]
Message-ID: <f5ebecbcedd69e45c5a60ee0e5c5ffe02e52b333.1282798831.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1282798831.git.amit.shah@redhat.com>
In-Reply-To: <cover.1282798831.git.amit.shah@redhat.com>
virtcons_remove is called on device unplug. Mark with __devexit_p.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 92ae3f8..a34f40e 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1585,7 +1585,7 @@ fail:
return err;
}
-static void virtcons_remove(struct virtio_device *vdev)
+static void __devexit virtcons_remove(struct virtio_device *vdev)
{
struct ports_device *portdev;
struct port *port, *port2;
@@ -1631,7 +1631,7 @@ static struct virtio_driver virtio_console = {
.driver.owner = THIS_MODULE,
.id_table = id_table,
.probe = virtcons_probe,
- .remove = virtcons_remove,
+ .remove = __devexit_p(virtcons_remove),
.config_changed = config_intr,
};
--
1.7.2.2
next prev parent reply other threads:[~2010-08-26 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 5:04 [PATCH 0/4] virtio: console: fixes, SIGIO Amit Shah
2010-08-26 5:04 ` [PATCH 1/4] virtio: console: Un-block reads on chardev close Amit Shah
2010-08-26 5:04 ` Amit Shah [this message]
2010-08-26 5:04 ` [PATCH 3/4] virtio: console: Send SIGIO to processes that request it for host events Amit Shah
2010-08-26 5:04 ` [PATCH 4/4] virtio: console: Send SIGIO on new data arrival on ports Amit Shah
2010-08-31 11:36 ` [PATCH 0/4] virtio: console: fixes, SIGIO Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ebecbcedd69e45c5a60ee0e5c5ffe02e52b333.1282798831.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).