From: Amit Shah <amit@infradead.org>
To: Andy Bui <andy.bui2001@gmail.com>, amit@kernel.org
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio: console: remove check for cpkt value when nominating console port
Date: Mon, 14 Nov 2022 09:43:48 -0800 [thread overview]
Message-ID: <f638782743aa6d848af36cba36e9e039e2087d2b.camel@infradead.org> (raw)
In-Reply-To: <20221112124522.3981-1-andy.bui2001@gmail.com>
On Sat, 2022-11-12 at 23:45 +1100, Andy Bui wrote:
> The virtIO spec does not specify a need for a value when nominating a
> port as a console port, yet the virtio_console driver requires the value
> to be 1.
>
> Besides being a check that's not specified by the virtIO spec, I don't
> see anywhere else in the kernel the value is used when the corresponding
> event is VIRTIO_CONSOLE_CONSOLE_PORT. As an example QEMU also currently
> only passes in value=1 when nominating a console port.
The original virtio-console driver just had the one port, and it was,
as the name suggests, was a console port. When we converted this
console driver to a generic serial driver, the first port was kept as
the console port to not break old drivers or hypervisors. I'm afraid
we'll have to keep this bit of backward compatibility forever.
Amit
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2022-11-14 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221112124522.3981-1-andy.bui2001@gmail.com>
2022-11-14 17:43 ` Amit Shah [this message]
2022-11-15 3:13 ` [PATCH] virtio: console: remove check for cpkt value when nominating console port Andy Bui
2022-11-23 10:46 ` Amit Shah
2022-11-29 7:28 ` Andy Bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f638782743aa6d848af36cba36e9e039e2087d2b.camel@infradead.org \
--to=amit@infradead.org \
--cc=amit@kernel.org \
--cc=andy.bui2001@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).