From: Markus Elfring <Markus.Elfring@web.de>
To: Xiong Weimin <xiongweimin@kylinos.cn>,
virtualization@lists.linux.dev,
Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH v2] vdpa: solidrun: Free IRQs after request failure
Date: Wed, 5 Aug 2026 07:40:12 +0200 [thread overview]
Message-ID: <f872c251-6558-44c5-8be3-e892afa5664f@web.de> (raw)
In-Reply-To: <178589471328.1556376.15570536900532373521@kylinos.cn>
> Unwind IRQs already requested by snet_request_irqs() before returning a
> VQ IRQ request error so a later DRIVER_OK retry starts from a clean
> state. The IRQs are requested and freed while the PCI device remains
> bound, so the driver cannot wait for devres cleanup at detach time.
I suggest to avoid duplicate SNET_ERR() calls for the implementation
of the function “snet_request_irqs”.
https://elixir.bootlin.com/linux/v7.2-rc5/source/drivers/vdpa/solidrun/snet_main.c#L400-L426
Regards,
Markus
prev parent reply other threads:[~2026-08-05 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 1:51 [PATCH v2] vdpa: solidrun: Free IRQs after request failure Xiong Weimin
2026-08-05 5:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f872c251-6558-44c5-8be3-e892afa5664f@web.de \
--to=markus.elfring@web.de \
--cc=alvaro.karsz@solid-run.com \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xiongweimin@kylinos.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox