From: Feng Liu via Virtualization <virtualization@lists.linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 0/3] virtio_ring: Clean up code for virtio ring and pci
Date: Fri, 10 Mar 2023 08:21:31 -0500 [thread overview]
Message-ID: <fb824fb0-1704-daeb-eb02-fdcfe1686902@nvidia.com> (raw)
In-Reply-To: <20230310030624-mutt-send-email-mst@kernel.org>
On 2023-03-10 a.m.3:06, Michael S. Tsirkin wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, Mar 10, 2023 at 07:34:25AM +0200, Feng Liu wrote:
>> This patch series performs a clean up of the code in virtio_ring and
>> virtio_pci, modifying it to conform with the Linux kernel coding style
>> guidance [1]. The modifications ensure the code easy to read and
>> understand. This small series does few short cleanups in the code.
>>
>> Patch-1 Allow non power of 2 sizes for virtqueues
>> Patch-2 Avoid using inline for small functions.
>> Patch-3 Use const to annotate read-only pointer params.
>>
>> [1]
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv6.2-rc3%2Fprocess%2Fcoding-style.html%23the-inline-disease&data=05%7C01%7Cfeliu%40nvidia.com%7C08831607a6fb4f58881408db213f8638%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638140328946332918%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FnD4GINUds2HLLo47aY5Ps%2B9nKWPW2XRI35z1Hp0yx4%3D&reserved=0
>>
>> All of the patches have been verified based on the kernel code
>> commit 44889ba56cbb ("Merge tag 'net-6.3-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
>
> verified how?
>
Hi Michael
1. Applied the patches on lastest kernel source(44889ba56cbb), compile
and install the kernel, and use iperf to test traffic
2. To validate this change, we tested various virtqueue sizes for packed
rings, including 128, 256, 512, 100, 200, 500, and 1000, with
CONFIG_PAGE_POISONING enabled, and test by iperf& ping -f and all tests
passed successfully.
>> Feng Liu (3):
>> virtio_pci_modern: Allow non power of 2 sizes for virtqueues
>> virtio_ring: Avoid using inline for small functions
>> virtio_ring: Use const to annotate read-only pointer params
>>
>> drivers/virtio/virtio_pci_modern.c | 5 ----
>> drivers/virtio/virtio_ring.c | 48 +++++++++++++++---------------
>> include/linux/virtio.h | 14 ++++-----
>> 3 files changed, 31 insertions(+), 36 deletions(-)
>>
>> --
>> 2.34.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-03-10 13:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 5:34 [PATCH v2 0/3] virtio_ring: Clean up code for virtio ring and pci Feng Liu via Virtualization
2023-03-10 5:34 ` [PATCH v2 1/3] virtio_pci_modern: Allow non power of 2 sizes for virtqueues Feng Liu via Virtualization
2023-03-10 13:36 ` Parav Pandit via Virtualization
2023-03-10 15:23 ` Feng Liu via Virtualization
2023-03-11 19:05 ` Michael S. Tsirkin
2023-03-11 22:25 ` Feng Liu via Virtualization
2023-03-12 6:46 ` Michael S. Tsirkin
2023-03-12 12:05 ` Feng Liu via Virtualization
2023-03-10 5:34 ` [PATCH v2 2/3] virtio_ring: Avoid using inline for small functions Feng Liu via Virtualization
2023-03-10 5:34 ` [PATCH v2 3/3] virtio_ring: Use const to annotate read-only pointer params Feng Liu via Virtualization
2023-03-10 8:06 ` [PATCH v2 0/3] virtio_ring: Clean up code for virtio ring and pci Michael S. Tsirkin
2023-03-10 13:21 ` Feng Liu via Virtualization [this message]
2023-03-11 19:06 ` Michael S. Tsirkin
2023-03-11 22:19 ` Feng Liu via Virtualization
2023-03-12 6:47 ` Michael S. Tsirkin
2023-03-12 12:00 ` Feng Liu via Virtualization
-- strict thread matches above, loose matches on Subject: below --
2023-03-15 18:54 Feng Liu via Virtualization
2023-03-31 4:20 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb824fb0-1704-daeb-eb02-fdcfe1686902@nvidia.com \
--to=virtualization@lists.linux-foundation.org \
--cc=feliu@nvidia.com \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).