From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A97C1586EC for ; Thu, 1 Feb 2024 07:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706773455; cv=none; b=S5KmEvHZ4v2uTpE5ZOOzahDTbey/I9zAlDKDmzloYAEp1CIASCY9ee2YJEg9xgh/swdNHU1qOpyne77F6lhhQlbO+akP7jYedz865qTAvGLb0qqiYxsHRHc+Zp3hj88PGNxDu+si5dCgleCceqTfsNpGz2xbwLTcerkWW2ytcjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706773455; c=relaxed/simple; bh=VUxkMaWDzVG8ks5grBa6GIO8EpjRdlccwEaXcMtktI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hnDaQsMt5Pw1WvRjWemN2CYLc/azteMjYHgyymEW6W71SmzdmdcV2BXPxXnEzfTlmmida2Z/hdJQCfYTxGdpEQsO6pDwU+XO8rsTHxvtVH7wydfpZ6Jviy2nKKfAIVRHeaYLNd40yrth6HqkDf4ksoAwETxCNiO2Le9VXQW3FB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BTi5Srt3; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BTi5Srt3" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706773449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W+Ldjee8H+rdTycXwv7iNM7fs8dOnUOKfLYDOYFBKVs=; b=BTi5Srt3XKJ6GI3RHRfeEo1l/LIcvsed3vksfXGfzoNkv2bVp9RgtmgnorM1PflB601mio ZFYZWsWXuDV9CHI2hA0a6mHsCy0fjvtfbHXRWJUGYQG/TN+xsopEpfQy0//LmahUgBBaBR ctnB69aOTsyBQtqsU/VGoDWvQfeYCms= Date: Thu, 1 Feb 2024 15:43:51 +0800 Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq To: Xuan Zhuo , virtualization@lists.linux.dev Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Benjamin Berg , Yang Li , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org References: <20240130114224.86536-1-xuanzhuo@linux.alibaba.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20240130114224.86536-1-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2024/1/30 19:42, Xuan Zhuo 写道: > As discussed: > http://lore.kernel.org/all/CACGkMEvq0No8QGC46U4mGsMtuD44fD_cfLcPaVmJ3rHYqRZxYg@mail.gmail.com > > If the virtio is premapped mode, the driver should manage the dma info by self. > So the virtio core should not store the dma info. > So we can release the memory used to store the dma info. > > But if the desc_extra has not dma info, we face a new question, > it is hard to get the dma info of the desc with indirect flag. > For split mode, that is easy from desc, but for the packed mode, > it is hard to get the dma info from the desc. And for hardening > the dma unmap is saft, we should store the dma info of indirect > descs. > > So I introduce the "structure the indirect desc table" to > allocate space to store dma info with the desc table. > > On the other side, we mix the descs with indirect flag > with other descs together to share the unmap api. That > is complex. I found if we we distinguish the descs with > VRING_DESC_F_INDIRECT before unmap, thing will be clearer. > > Because of the dma array is allocated in the find_vqs(), > so I introduce a new parameter to find_vqs(). > > Please review. > > Thanks > > Xuan Zhuo (17): > virtio_ring: introduce vring_need_unmap_buffer > virtio_ring: packed: remove double check of the unmap ops > virtio_ring: packed: structure the indirect desc table > virtio_ring: split: remove double check of the unmap ops > virtio_ring: split: structure the indirect desc table > virtio_ring: no store dma info when unmap is not needed > virtio: find_vqs: pass struct instead of multi parameters > virtio: vring_new_virtqueue(): pass struct instead of multi parameters > virtio_ring: reuse the parameter struct of find_vqs() > virtio: find_vqs: add new parameter premapped > virtio_ring: export premapped to driver by struct virtqueue > virtio_net: set premapped mode by find_vqs() > virtio_ring: remove api of setting vq premapped > virtio_ring: introduce dma map api for page > virtio_net: unify the code for recycling the xmit ptr > virtio_net: rename free_old_xmit_skbs to free_old_xmit > virtio_net: sq support premapped mode The above can not be cleanly merged into kernel 6.8-rc2. Perhaps a base-commit is needed. About base-commit, please see the link https://people.kernel.org/monsieuricon/all-patches-must-include-base-commit-info Zhu Yanjun > > arch/um/drivers/virtio_uml.c | 29 +- > drivers/net/virtio_net.c | 298 +++++++--- > drivers/platform/mellanox/mlxbf-tmfifo.c | 24 +- > drivers/remoteproc/remoteproc_virtio.c | 31 +- > drivers/s390/virtio/virtio_ccw.c | 33 +- > drivers/virtio/virtio_mmio.c | 30 +- > drivers/virtio/virtio_pci_common.c | 59 +- > drivers/virtio/virtio_pci_common.h | 9 +- > drivers/virtio/virtio_pci_legacy.c | 16 +- > drivers/virtio/virtio_pci_modern.c | 24 +- > drivers/virtio/virtio_ring.c | 660 ++++++++++++----------- > drivers/virtio/virtio_vdpa.c | 33 +- > include/linux/virtio.h | 10 +- > include/linux/virtio_config.h | 48 +- > include/linux/virtio_ring.h | 82 +-- > tools/virtio/virtio_test.c | 4 +- > tools/virtio/vringh_test.c | 32 +- > 17 files changed, 812 insertions(+), 610 deletions(-) > > -- > 2.32.0.3.g01195cf9f >