From: Jason Wang <jasowang@redhat.com>
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
"David S . Miller" <davem@davemloft.net>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next] virtio_net: Add ethtool stats
Date: Wed, 20 Dec 2017 16:13:31 +0800 [thread overview]
Message-ID: <ff4eb1b4-e49f-2c5d-8e99-810093643c5c@redhat.com> (raw)
In-Reply-To: <1513744837-2672-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On 2017年12月20日 12:40, Toshiaki Makita wrote:
> The main purpose of this patch is adding a way of checking per-queue stats.
> It's useful to debug performance problems on multiqueue environment.
>
> $ ethtool -S ens10
> NIC statistics:
> rx_packets: 4172939
> tx_packets: 5855538
> rx_bytes: 6317757408
> tx_bytes: 8865151846
> rx_dropped: 0
> rx_length_errors: 0
> rx_frame_errors: 0
> tx_dropped: 0
> tx_fifo_errors: 0
> rx_queue_0_packets: 2090408
> rx_queue_0_bytes: 3164825094
> rx_queue_1_packets: 2082531
> rx_queue_1_bytes: 3152932314
> tx_queue_0_packets: 2770841
> tx_queue_0_bytes: 4194955474
> tx_queue_1_packets: 3084697
> tx_queue_1_bytes: 4670196372
>
> Signed-off-by: Toshiaki Makita<makita.toshiaki@lab.ntt.co.jp>
Thanks for the patch. This is not the first patch that wants to do this.
Maybe you can go through the previous comments (E.g there's one in
https://patchwork.ozlabs.org/patch/244413/).
For me, I'd expect to add some XDP counters like other device did.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2017-12-20 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1513744837-2672-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
2017-12-20 8:13 ` Jason Wang [this message]
2017-12-21 2:12 ` [PATCH net-next] virtio_net: Add ethtool stats Toshiaki Makita
2017-12-24 18:16 ` Stephen Hemminger
[not found] ` <20171224101640.4b14002f@xeon-e3>
2017-12-25 11:45 ` Toshiaki Makita
2017-12-25 16:47 ` Florian Fainelli
[not found] ` <25B612A0-B4BD-4CE9-A166-8630F7F4BD76@gmail.com>
2017-12-26 6:41 ` Toshiaki Makita
2017-12-20 4:40 Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4eb1b4-e49f-2c5d-8e99-810093643c5c@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox