virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andi Kleen <ak@suse.de>, Rusty Russell <rusty@rustcorp.com.au>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: James.Bottomley@HansenPartnership.com, virtualization@lists.osdl.org
Subject: The virtuailization patches break Voyager.
Date: Sat, 28 Apr 2007 00:40:33 -0600	[thread overview]
Message-ID: <m1mz0tgfxa.fsf@ebiederm.dsl.xmission.com> (raw)


Guys currently I am horrified by the ease at which I can find
bugs in the pending paravirtualization patches.  I have barely
even looked at arch/i386 in the -mm tree and it feels like
I am tripping over significant bugs left and right.

Because no one has heeded my advice and put in a proper platform
layer on arch/i386 and we are instead doing a half baked job
with paravirt_ops it is still trivially easy to miss the
fact that subarchitectures do something different, and thus
it is easy to miss when you break a sub architecture on
arch/i386.

Not that the paravirtuailzation patches are even safe on the
primary arch/i386.

To some extent I grant with major changes a little goofing up on
pending patches is to be expected, but it would be nice if
things were restructured to make it harder to miss the
subarchitectures on arch/i386.

The patch known as x86_64-mm-use-per-cpu-gdt-immediately-upon-boot
on -mm currently breaks voyager smp support in some very obvious ways.

Making init_gdt a function which is called from voyager_smp.c static
in smpboot.c a file that is not even used on voayger is an obvious
one.

Adding start_pda and not setting it in voyager_smp is another.

Rusty do you think you can address this?

Eric

             reply	other threads:[~2007-04-28  6:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28  6:40 Eric W. Biederman [this message]
2007-04-28  6:59 ` The virtuailization patches break Voyager Jeremy Fitzhardinge
2007-04-28  7:25   ` Eric W. Biederman
2007-04-28  7:52     ` Jeremy Fitzhardinge
2007-04-28  8:32       ` Eric W. Biederman
2007-04-28  8:52         ` Jeremy Fitzhardinge
2007-04-28  9:34         ` Andi Kleen
2007-04-28 16:05           ` James Bottomley
2007-04-28 17:15             ` Andi Kleen
2007-04-28  8:42       ` Andi Kleen
2007-04-28  9:13         ` Thomas Gleixner
2007-04-28  9:15           ` Jeremy Fitzhardinge
2007-04-28  9:39           ` Andi Kleen
2007-04-28  9:48             ` Thomas Gleixner
2007-04-28  9:15         ` Eric W. Biederman
2007-04-28  9:37           ` Andi Kleen
2007-04-28 15:24             ` Eric W. Biederman
2007-04-28 16:08             ` James Bottomley
2007-04-28 15:54         ` James Bottomley
2007-04-28 17:15           ` Andi Kleen
2007-04-28 16:40       ` H. Peter Anvin
2007-04-28 17:00         ` Eric W. Biederman
2007-04-28 17:07           ` H. Peter Anvin
2007-04-28 15:47 ` James Bottomley
2007-04-28 16:02   ` Eric W. Biederman
2007-04-28 16:18     ` Jeremy Fitzhardinge
2007-04-28 16:20     ` James Bottomley
2007-04-28 17:23       ` Andi Kleen
2007-04-28 17:22   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1mz0tgfxa.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).