* [PATCH 13/16] drm/virtio: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:19 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index a165f03..6a6cb73 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -237,13 +237,6 @@ virtio_gpu_framebuffer_init(struct drm_device *dev,
return 0;
}
-static bool virtio_gpu_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void virtio_gpu_crtc_mode_set_nofb(struct drm_crtc *crtc)
{
struct drm_device *dev = crtc->dev;
@@ -277,7 +270,6 @@ static int virtio_gpu_crtc_atomic_check(struct drm_crtc *crtc,
static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = {
.enable = virtio_gpu_crtc_enable,
.disable = virtio_gpu_crtc_disable,
- .mode_fixup = virtio_gpu_crtc_mode_fixup,
.mode_set_nofb = virtio_gpu_crtc_mode_set_nofb,
.atomic_check = virtio_gpu_crtc_atomic_check,
};
--
2.5.0
^ permalink raw reply related
* [PATCH 12/16] drm/nouveau/dispnv04: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:19 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index 6f04397..55ccbf0 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -227,13 +227,6 @@ nv_crtc_dpms(struct drm_crtc *crtc, int mode)
NVWriteVgaCrtc(dev, nv_crtc->index, NV_CIO_CRE_RPC1_INDEX, crtc1A);
}
-static bool
-nv_crtc_mode_fixup(struct drm_crtc *crtc, const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void
nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
{
@@ -1093,7 +1086,6 @@ static const struct drm_crtc_helper_funcs nv04_crtc_helper_funcs = {
.dpms = nv_crtc_dpms,
.prepare = nv_crtc_prepare,
.commit = nv_crtc_commit,
- .mode_fixup = nv_crtc_mode_fixup,
.mode_set = nv_crtc_mode_set,
.mode_set_base = nv04_crtc_mode_set_base,
.mode_set_base_atomic = nv04_crtc_mode_set_base_atomic,
--
2.5.0
^ permalink raw reply related
* [PATCH 11/16] drm/atmel-hldcd: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:19 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
index 9863291..58c4f78 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
@@ -121,13 +121,6 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
cfg);
}
-static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void atmel_hlcdc_crtc_disable(struct drm_crtc *c)
{
struct drm_device *dev = c->dev;
@@ -261,7 +254,6 @@ static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc,
}
static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = {
- .mode_fixup = atmel_hlcdc_crtc_mode_fixup,
.mode_set = drm_helper_crtc_mode_set,
.mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb,
.mode_set_base = drm_helper_crtc_mode_set_base,
@@ -349,4 +341,3 @@ fail:
atmel_hlcdc_crtc_destroy(&crtc->base);
return ret;
}
-
--
2.5.0
^ permalink raw reply related
* [PATCH 10/16] drm/sti: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:18 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/sti/sti_crtc.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
index de11c7c..e04deed 100644
--- a/drivers/gpu/drm/sti/sti_crtc.c
+++ b/drivers/gpu/drm/sti/sti_crtc.c
@@ -51,14 +51,6 @@ static void sti_crtc_disabling(struct drm_crtc *crtc)
mixer->status = STI_MIXER_DISABLING;
}
-static bool sti_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- /* accept the provided drm_display_mode, do not fix it up */
- return true;
-}
-
static int
sti_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode)
{
@@ -229,7 +221,6 @@ static void sti_crtc_atomic_flush(struct drm_crtc *crtc,
static const struct drm_crtc_helper_funcs sti_crtc_helper_funcs = {
.enable = sti_crtc_enable,
.disable = sti_crtc_disabling,
- .mode_fixup = sti_crtc_mode_fixup,
.mode_set = drm_helper_crtc_mode_set,
.mode_set_nofb = sti_crtc_mode_set_nofb,
.mode_set_base = drm_helper_crtc_mode_set_base,
--
2.5.0
^ permalink raw reply related
* [PATCH 09/16] drm/shmobile: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:18 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
index 27342fd..88643ab 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
@@ -359,13 +359,6 @@ static void shmob_drm_crtc_dpms(struct drm_crtc *crtc, int mode)
scrtc->dpms = mode;
}
-static bool shmob_drm_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void shmob_drm_crtc_mode_prepare(struct drm_crtc *crtc)
{
shmob_drm_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
@@ -431,7 +424,6 @@ static int shmob_drm_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
.dpms = shmob_drm_crtc_dpms,
- .mode_fixup = shmob_drm_crtc_mode_fixup,
.prepare = shmob_drm_crtc_mode_prepare,
.commit = shmob_drm_crtc_mode_commit,
.mode_set = shmob_drm_crtc_mode_set,
--
2.5.0
^ permalink raw reply related
* [PATCH 08/16] drm/msm/mdp: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:18 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 8 --------
drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 8 --------
2 files changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
index 909d742..38329a6 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
@@ -147,13 +147,6 @@ static void mdp4_crtc_destroy(struct drm_crtc *crtc)
kfree(mdp4_crtc);
}
-static bool mdp4_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
/* statically (for now) map planes to mixer stage (z-order): */
static const int idxs[] = {
[VG1] = 1,
@@ -508,7 +501,6 @@ static const struct drm_crtc_funcs mdp4_crtc_funcs = {
};
static const struct drm_crtc_helper_funcs mdp4_crtc_helper_funcs = {
- .mode_fixup = mdp4_crtc_mode_fixup,
.mode_set_nofb = mdp4_crtc_mode_set_nofb,
.disable = mdp4_crtc_disable,
.enable = mdp4_crtc_enable,
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
index 46682aa..d6b45eb 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
@@ -185,13 +185,6 @@ static void mdp5_crtc_destroy(struct drm_crtc *crtc)
kfree(mdp5_crtc);
}
-static bool mdp5_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
/*
* blend_setup() - blend all the planes of a CRTC
*
@@ -634,7 +627,6 @@ static const struct drm_crtc_funcs mdp5_crtc_funcs = {
};
static const struct drm_crtc_helper_funcs mdp5_crtc_helper_funcs = {
- .mode_fixup = mdp5_crtc_mode_fixup,
.mode_set_nofb = mdp5_crtc_mode_set_nofb,
.disable = mdp5_crtc_disable,
.enable = mdp5_crtc_enable,
--
2.5.0
^ permalink raw reply related
* [PATCH 07/16] drm/omapdrm: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:18 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
index d38fcbc..483acdb 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
@@ -330,13 +330,6 @@ static void omap_crtc_destroy(struct drm_crtc *crtc)
kfree(omap_crtc);
}
-static bool omap_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void omap_crtc_enable(struct drm_crtc *crtc)
{
struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
@@ -451,7 +444,6 @@ static const struct drm_crtc_funcs omap_crtc_funcs = {
};
static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = {
- .mode_fixup = omap_crtc_mode_fixup,
.mode_set_nofb = omap_crtc_mode_set_nofb,
.disable = omap_crtc_disable,
.enable = omap_crtc_enable,
--
2.5.0
^ permalink raw reply related
* [PATCH 06/16] drm/rcar-du: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:18 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 4ec80ae..627abc80 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -468,14 +468,6 @@ static void rcar_du_crtc_disable(struct drm_crtc *crtc)
rcrtc->outputs = 0;
}
-static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- /* TODO Fixup modes */
- return true;
-}
-
static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
struct drm_crtc_state *old_crtc_state)
{
@@ -502,7 +494,6 @@ static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
}
static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
- .mode_fixup = rcar_du_crtc_mode_fixup,
.disable = rcar_du_crtc_disable,
.enable = rcar_du_crtc_enable,
.atomic_begin = rcar_du_crtc_atomic_begin,
--
2.5.0
^ permalink raw reply related
* [PATCH 05/16] drm/gma: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:17 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 13 ++++++-------
drivers/gpu/drm/gma500/gma_display.c | 7 -------
drivers/gpu/drm/gma500/gma_display.h | 3 ---
drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 --
drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 -
drivers/gpu/drm/gma500/psb_intel_display.c | 1 -
6 files changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
index 6126546..17db4b4 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_display.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
@@ -116,7 +116,7 @@ static const struct gma_limit_t cdv_intel_limits[] = {
.p1 = {.min = 1, .max = 10},
.p2 = {.dot_limit = 225000, .p2_slow = 10, .p2_fast = 10},
.find_pll = cdv_intel_find_dp_pll,
- }
+ }
};
#define _wait_for(COND, MS, W) ({ \
@@ -245,7 +245,7 @@ cdv_dpll_set_clock_cdv(struct drm_device *dev, struct drm_crtc *crtc,
/* We don't know what the other fields of these regs are, so
* leave them in place.
*/
- /*
+ /*
* The BIT 14:13 of 0x8010/0x8030 is used to select the ref clk
* for the pipe A/B. Display spec 1.06 has wrong definition.
* Correct definition is like below:
@@ -256,7 +256,7 @@ cdv_dpll_set_clock_cdv(struct drm_device *dev, struct drm_crtc *crtc,
*
* if DPLLA sets 01 and DPLLB sets 02, both use clk from DPLLA
*
- */
+ */
ret = cdv_sb_read(dev, ref_sfr, &ref_value);
if (ret)
return ret;
@@ -646,7 +646,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
* for DP/eDP. When using SSC clock, the ref clk is 100MHz.Otherwise
* it will be 27MHz. From the VBIOS code it seems that the pipe A choose
* 27MHz for DP/eDP while the Pipe B chooses the 100MHz.
- */
+ */
if (pipe == 0)
refclk = 27000;
else
@@ -659,7 +659,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
}
drm_mode_debug_printmodeline(adjusted_mode);
-
+
limit = gma_crtc->clock_funcs->limit(crtc, refclk);
ok = limit->find_pll(limit, crtc, adjusted_mode->clock, refclk,
@@ -721,7 +721,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
pipeconf |= PIPE_6BPC;
} else
pipeconf |= PIPE_8BPC;
-
+
/* Set up the display plane register */
dspcntr = DISPPLANE_GAMMA_ENABLE;
@@ -974,7 +974,6 @@ struct drm_display_mode *cdv_intel_crtc_mode_get(struct drm_device *dev,
const struct drm_crtc_helper_funcs cdv_intel_helper_funcs = {
.dpms = gma_crtc_dpms,
- .mode_fixup = gma_crtc_mode_fixup,
.mode_set = cdv_intel_crtc_mode_set,
.mode_set_base = gma_pipe_set_base,
.prepare = gma_crtc_prepare,
diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
index ff17af4..d6a5c77 100644
--- a/drivers/gpu/drm/gma500/gma_display.c
+++ b/drivers/gpu/drm/gma500/gma_display.c
@@ -485,13 +485,6 @@ bool gma_encoder_mode_fixup(struct drm_encoder *encoder,
return true;
}
-bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
void gma_crtc_prepare(struct drm_crtc *crtc)
{
const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
diff --git a/drivers/gpu/drm/gma500/gma_display.h b/drivers/gpu/drm/gma500/gma_display.h
index ed569d8..fc64241 100644
--- a/drivers/gpu/drm/gma500/gma_display.h
+++ b/drivers/gpu/drm/gma500/gma_display.h
@@ -75,9 +75,6 @@ extern void gma_crtc_load_lut(struct drm_crtc *crtc);
extern void gma_crtc_gamma_set(struct drm_crtc *crtc, u16 *red, u16 *green,
u16 *blue, u32 start, u32 size);
extern void gma_crtc_dpms(struct drm_crtc *crtc, int mode);
-extern bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode);
extern void gma_crtc_prepare(struct drm_crtc *crtc);
extern void gma_crtc_commit(struct drm_crtc *crtc);
extern void gma_crtc_disable(struct drm_crtc *crtc);
diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
index acd3834..92e3f93e 100644
--- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
+++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
@@ -1026,10 +1026,8 @@ mrst_crtc_mode_set_exit:
const struct drm_crtc_helper_funcs mdfld_helper_funcs = {
.dpms = mdfld_crtc_dpms,
- .mode_fixup = gma_crtc_mode_fixup,
.mode_set = mdfld_crtc_mode_set,
.mode_set_base = mdfld__intel_pipe_set_base,
.prepare = gma_crtc_prepare,
.commit = gma_crtc_commit,
};
-
diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
index 1048f0c..da9fd34 100644
--- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
+++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
@@ -657,7 +657,6 @@ pipe_set_base_exit:
const struct drm_crtc_helper_funcs oaktrail_helper_funcs = {
.dpms = oaktrail_crtc_dpms,
- .mode_fixup = gma_crtc_mode_fixup,
.mode_set = oaktrail_crtc_mode_set,
.mode_set_base = oaktrail_pipe_set_base,
.prepare = gma_crtc_prepare,
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
index dcdbc37..398015b 100644
--- a/drivers/gpu/drm/gma500/psb_intel_display.c
+++ b/drivers/gpu/drm/gma500/psb_intel_display.c
@@ -430,7 +430,6 @@ struct drm_display_mode *psb_intel_crtc_mode_get(struct drm_device *dev,
const struct drm_crtc_helper_funcs psb_intel_helper_funcs = {
.dpms = gma_crtc_dpms,
- .mode_fixup = gma_crtc_mode_fixup,
.mode_set = psb_intel_crtc_mode_set,
.mode_set_base = gma_pipe_set_base,
.prepare = gma_crtc_prepare,
--
2.5.0
^ permalink raw reply related
* [PATCH 04/16] drm/udl: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:17 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/udl/udl_modeset.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 160ef2a..b87afee 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -279,14 +279,6 @@ static void udl_crtc_dpms(struct drm_crtc *crtc, int mode)
}
-static bool udl_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-
-{
- return true;
-}
-
#if 0
static int
udl_pipe_set_base_atomic(struct drm_crtc *crtc, struct drm_framebuffer *fb,
@@ -402,7 +394,6 @@ static void udl_crtc_commit(struct drm_crtc *crtc)
static const struct drm_crtc_helper_funcs udl_helper_funcs = {
.dpms = udl_crtc_dpms,
- .mode_fixup = udl_crtc_mode_fixup,
.mode_set = udl_crtc_mode_set,
.prepare = udl_crtc_prepare,
.commit = udl_crtc_commit,
--
2.5.0
^ permalink raw reply related
* [PATCH 03/16] drm/mgag200: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:17 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index dc13c48..aa99c40 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -92,18 +92,6 @@ static inline void mga_wait_busy(struct mga_device *mdev)
} while ((status & 0x01) && time_before(jiffies, timeout));
}
-/*
- * The core passes the desired mode to the CRTC code to see whether any
- * CRTC-specific modifications need to be made to it. We're in a position
- * to just pass that straight through, so this does nothing
- */
-static bool mga_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
#define P_ARRAY_SIZE 9
static int mga_g200se_set_plls(struct mga_device *mdev, long clock)
@@ -1410,7 +1398,6 @@ static const struct drm_crtc_funcs mga_crtc_funcs = {
static const struct drm_crtc_helper_funcs mga_helper_funcs = {
.disable = mga_crtc_disable,
.dpms = mga_crtc_dpms,
- .mode_fixup = mga_crtc_mode_fixup,
.mode_set = mga_crtc_mode_set,
.mode_set_base = mga_crtc_mode_set_base,
.prepare = mga_crtc_prepare,
--
2.5.0
^ permalink raw reply related
* [PATCH 02/16] drm/cirrus: removed optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:16 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/cirrus/cirrus_mode.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c
index 4a02854..e7334a8 100644
--- a/drivers/gpu/drm/cirrus/cirrus_mode.c
+++ b/drivers/gpu/drm/cirrus/cirrus_mode.c
@@ -91,18 +91,6 @@ static void cirrus_crtc_dpms(struct drm_crtc *crtc, int mode)
WREG_GFX(0xe, gr0e);
}
-/*
- * The core passes the desired mode to the CRTC code to see whether any
- * CRTC-specific modifications need to be made to it. We're in a position
- * to just pass that straight through, so this does nothing
- */
-static bool cirrus_crtc_mode_fixup(struct drm_crtc *crtc,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void cirrus_set_start_address(struct drm_crtc *crtc, unsigned offset)
{
struct cirrus_device *cdev = crtc->dev->dev_private;
@@ -372,7 +360,6 @@ static const struct drm_crtc_funcs cirrus_crtc_funcs = {
static const struct drm_crtc_helper_funcs cirrus_helper_funcs = {
.dpms = cirrus_crtc_dpms,
- .mode_fixup = cirrus_crtc_mode_fixup,
.mode_set = cirrus_crtc_mode_set,
.mode_set_base = cirrus_crtc_mode_set_base,
.prepare = cirrus_crtc_prepare,
--
2.5.0
^ permalink raw reply related
* [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.
From: Carlos Palminha @ 2016-02-16 14:10 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
In-Reply-To: <cover.1455630967.git.palminha@synopsys.com>
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index e70d064..7539eea 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -343,9 +343,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
}
}
- if (!(ret = crtc_funcs->mode_fixup(crtc, mode, adjusted_mode))) {
- DRM_DEBUG_KMS("CRTC fixup failed\n");
- goto done;
+ if (crtc_funcs->mode_fixup) {
+ if (!(ret = crtc_funcs->mode_fixup(crtc, mode,
+ adjusted_mode))) {
+ DRM_DEBUG_KMS("CRTC fixup failed\n");
+ goto done;
+ }
}
DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
--
2.5.0
^ permalink raw reply related
* [PATCH 00/16] drm crtc cleanup: nuke optional dummy crtc mode_fixup function.
From: Carlos Palminha @ 2016-02-16 14:09 UTC (permalink / raw)
To: airlied, dri-devel, daniel.vetter, patrik.r.jakobsson,
virtualization
Cc: nicolas.pitre, boris.brezillon, jianwei.wang.chn, jani.nikula,
alison.wang, CARLOS.PALMINHA, linux-renesas-soc, laurent.pinchart,
benjamin.gaignard, vincent.abriou, sudipm.mukherjee
This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Carlos Palminha (16):
drm: fixes crct set_mode when crtc mode_fixup is null.
drm/cirrus: removed optional dummy crtc mode_fixup function.
drm/mgag200: removed optional dummy crtc mode_fixup function.
drm/udl: removed optional dummy crtc mode_fixup function.
drm/gma: removed optional dummy crtc mode_fixup function.
drm/rcar-du: removed optional dummy crtc mode_fixup function.
drm/omapdrm: removed optional dummy crtc mode_fixup function.
drm/msm/mdp: removed optional dummy crtc mode_fixup function.
drm/shmobile: removed optional dummy crtc mode_fixup function.
drm/sti: removed optional dummy crtc mode_fixup function.
drm/atmel-hldcd: removed optional dummy crtc mode_fixup function.
drm/nouveau/dispnv04: removed optional dummy crtc mode_fixup function.
drm/virtio: removed optional dummy crtc mode_fixup function.
drm/fsl-dcu: removed optional dummy crtc mode_fixup function.
drm/bochs: removed optional dummy crtc mode_fixup function.
drm/ast: removed optional dummy crtc mode_fixup function.
drivers/gpu/drm/ast/ast_mode.c | 8 --------
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ---------
drivers/gpu/drm/bochs/bochs_kms.c | 8 --------
drivers/gpu/drm/cirrus/cirrus_mode.c | 13 -------------
drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 8 --------
drivers/gpu/drm/gma500/cdv_intel_display.c | 13 ++++++-------
drivers/gpu/drm/gma500/gma_display.c | 7 -------
drivers/gpu/drm/gma500/gma_display.h | 3 ---
drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 --
drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 -
drivers/gpu/drm/gma500/psb_intel_display.c | 1 -
drivers/gpu/drm/mgag200/mgag200_mode.c | 13 -------------
drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 8 --------
drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 8 --------
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 8 --------
drivers/gpu/drm/omapdrm/omap_crtc.c | 8 --------
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 ---------
drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 8 --------
drivers/gpu/drm/sti/sti_crtc.c | 9 ---------
drivers/gpu/drm/udl/udl_modeset.c | 9 ---------
drivers/gpu/drm/virtio/virtgpu_display.c | 8 --------
22 files changed, 12 insertions(+), 158 deletions(-)
--
2.5.0
^ permalink raw reply
* Re: [PATCH v2 15/17] drm/rockchip: removed optional dummy encoder mode_fixup function.
From: Mark yao @ 2016-02-16 0:39 UTC (permalink / raw)
To: Carlos Palminha, dri-devel
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard, airlied,
jingoohan1, patrik.r.jakobsson, virtualization, linux-rockchip,
kgene, p.zabel, vincent.abriou, linux-arm-kernel
In-Reply-To: <cae559aa2c04a906c21ed5ebe4861f92440e6910.1455540137.git.palminha@synopsys.com>
On 2016年02月15日 21:01, Carlos Palminha wrote:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>
Acked-by: Mark Yao <mark.yao@rock-chips.com>
Thanks
Mark
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply
* Re: [PATCH v2 16/17] drm/sti: removed optional dummy encoder mode_fixup function.
From: Vincent ABRIOU @ 2016-02-15 16:44 UTC (permalink / raw)
To: Carlos Palminha, dri-devel@lists.freedesktop.org
Cc: k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org,
heiko@sntech.de, benjamin.gaignard@linaro.org, airlied@linux.ie,
jingoohan1@gmail.com, patrik.r.jakobsson@gmail.com,
virtualization@lists.linux-foundation.org,
linux-rockchip@lists.infradead.org, kgene@kernel.org,
p.zabel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
mark.yao@rock-chips.com
In-Reply-To: <7f47c6a7b00e4f16af672ebf3a277e31ad117e21.1455540137.git.palminha@synopsys.com>
On 02/15/2016 02:01 PM, Carlos Palminha wrote:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/gpu/drm/sti/sti_tvout.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
Acked-by: Vincent Abriou <vincent.abriou@st.com>
BR
Vincent
^ permalink raw reply
* Re: [PATCH v2 10/17] drm/imx: removed optional dummy encoder mode_fixup function.
From: Philipp Zabel @ 2016-02-15 16:16 UTC (permalink / raw)
To: Carlos Palminha
Cc: k.kozlowski, linux-samsung-soc, heiko, airlied, jingoohan1,
patrik.r.jakobsson, virtualization, linux-rockchip, kgene,
dri-devel, benjamin.gaignard, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <8bf274e8f6908142a9f940d3f2913e4a735e0caa.1455540137.git.palminha@synopsys.com>
Am Montag, den 15.02.2016, 13:00 +0000 schrieb Carlos Palminha:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply
* Re: [PATCH v2 03/17] drm/exynos: removed optional dummy encoder mode_fixup function.
From: Carlos Palminha @ 2016-02-15 15:18 UTC (permalink / raw)
To: Patrik Jakobsson, Carlos Palminha
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard,
David Airlie, jingoohan1, dri-devel, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <CAMeQTsZLdMOnk7-isneoUyFBbQdiRUsGH6+EhD8W1LNB=80LVQ@mail.gmail.com>
Hi Patrik,
No particular reason... i was grepping along the development and probably didn't noticed that exynos was not completely nuked... :)
Regards,
C.Palminha
On 15-02-2016 13:49, Patrik Jakobsson wrote:
> Hi Carlos
>
> Any particular reason why this patch isn't squashed with patch 8/17?
>
> Thanks
> Patrik
>
>
> On Mon, Feb 15, 2016 at 1:58 PM, Carlos Palminha
> <CARLOS.PALMINHA@synopsys.com> wrote:
>> mode_fixup function for encoder drivers became optional with patch
>> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>>
>> This patch set nukes all the dummy mode_fixup implementations.
>>
>> (made on top of Daniel topic/drm-misc branch)
>>
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> index e977a81..736115c 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> @@ -1597,13 +1597,6 @@ static int exynos_dsi_create_connector(struct drm_encoder *encoder)
>> return 0;
>> }
>>
>> -static bool exynos_dsi_mode_fixup(struct drm_encoder *encoder,
>> - const struct drm_display_mode *mode,
>> - struct drm_display_mode *adjusted_mode)
>> -{
>> - return true;
>> -}
>> -
>> static void exynos_dsi_mode_set(struct drm_encoder *encoder,
>> struct drm_display_mode *mode,
>> struct drm_display_mode *adjusted_mode)
>> @@ -1623,7 +1616,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder,
>> }
>>
>> static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = {
>> - .mode_fixup = exynos_dsi_mode_fixup,
>> .mode_set = exynos_dsi_mode_set,
>> .enable = exynos_dsi_enable,
>> .disable = exynos_dsi_disable,
>> --
>> 2.5.0
>>
^ permalink raw reply
* Re: [PATCH v2 09/17] drm/gma500: removed optional dummy encoder mode_fixup function.
From: Patrik Jakobsson @ 2016-02-15 14:24 UTC (permalink / raw)
To: Carlos Palminha
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard,
David Airlie, jingoohan1, dri-devel, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <b704458dc68a73cfb5507933c1df0c2a79e186eb.1455540137.git.palminha@synopsys.com>
On Mon, Feb 15, 2016 at 2:00 PM, Carlos Palminha
<CARLOS.PALMINHA@synopsys.com> wrote:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> ---
> drivers/gpu/drm/gma500/cdv_intel_crt.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 1 -
> drivers/gpu/drm/gma500/gma_display.c | 7 -------
> drivers/gpu/drm/gma500/gma_display.h | 3 ---
> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 1 -
> 5 files changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_crt.c b/drivers/gpu/drm/gma500/cdv_intel_crt.c
> index d0717a8..b837e7a 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_crt.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_crt.c
> @@ -217,7 +217,6 @@ static int cdv_intel_crt_set_property(struct drm_connector *connector,
>
> static const struct drm_encoder_helper_funcs cdv_intel_crt_helper_funcs = {
> .dpms = cdv_intel_crt_dpms,
> - .mode_fixup = gma_encoder_mode_fixup,
> .prepare = gma_encoder_prepare,
> .commit = gma_encoder_commit,
> .mode_set = cdv_intel_crt_mode_set,
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> index ddf2d77..28f9d90 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> @@ -255,7 +255,6 @@ static void cdv_hdmi_destroy(struct drm_connector *connector)
>
> static const struct drm_encoder_helper_funcs cdv_hdmi_helper_funcs = {
> .dpms = cdv_hdmi_dpms,
> - .mode_fixup = gma_encoder_mode_fixup,
> .prepare = gma_encoder_prepare,
> .mode_set = cdv_hdmi_mode_set,
> .commit = gma_encoder_commit,
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index ff17af4..9270821 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -478,13 +478,6 @@ int gma_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
> return 0;
> }
>
> -bool gma_encoder_mode_fixup(struct drm_encoder *encoder,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
> const struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> diff --git a/drivers/gpu/drm/gma500/gma_display.h b/drivers/gpu/drm/gma500/gma_display.h
> index ed569d8..78b9f98 100644
> --- a/drivers/gpu/drm/gma500/gma_display.h
> +++ b/drivers/gpu/drm/gma500/gma_display.h
> @@ -90,9 +90,6 @@ extern void gma_crtc_restore(struct drm_crtc *crtc);
> extern void gma_encoder_prepare(struct drm_encoder *encoder);
> extern void gma_encoder_commit(struct drm_encoder *encoder);
> extern void gma_encoder_destroy(struct drm_encoder *encoder);
> -extern bool gma_encoder_mode_fixup(struct drm_encoder *encoder,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode);
>
> /* Common clock related functions */
> extern const struct gma_limit_t *gma_limit(struct drm_crtc *crtc, int refclk);
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index 2d18499..8b2eb32 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -601,7 +601,6 @@ static void oaktrail_hdmi_destroy(struct drm_connector *connector)
>
> static const struct drm_encoder_helper_funcs oaktrail_hdmi_helper_funcs = {
> .dpms = oaktrail_hdmi_dpms,
> - .mode_fixup = gma_encoder_mode_fixup,
> .prepare = gma_encoder_prepare,
> .mode_set = oaktrail_hdmi_mode_set,
> .commit = gma_encoder_commit,
> --
> 2.5.0
>
^ permalink raw reply
* Re: [PATCH v2 00/17] drm encoders cleanup: nuke optional dummy encoder mode_fixup function.
From: Christian König @ 2016-02-15 14:19 UTC (permalink / raw)
To: Carlos Palminha, dri-devel
Cc: k.kozlowski, linux-samsung-soc, jingoohan1, virtualization,
linux-rockchip, kgene, benjamin.gaignard, vincent.abriou,
linux-arm-kernel
In-Reply-To: <cover.1455540137.git.palminha@synopsys.com>
Am 15.02.2016 um 13:57 schrieb Carlos Palminha:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Changes v1->v2: incorporated Daniel comments
> * added signed-off-by line to all patches
> * threading enabled due to e-mail server constraints
> * common blurb lines to all patches
> * add reviewed by Alex, to patches 4 and 14
You can add a Reviewed-by: Christian König <christian.koenig@amd.com> to
patch 4 and 14 as well.
Nice cleanup. Thanks,
Christian.
>
> Carlos Palminha (17):
> drm/virtio: removed optional dummy encoder mode_fixup function.
> drm/udl: removed optional dummy encoder mode_fixup function.
> drm/exynos: removed optional dummy encoder mode_fixup function.
> drm/amdgpu: removed optional dummy encoder mode_fixup function.
> drm/ast: removed optional dummy encoder mode_fixup function.
> drm/bochs: removed optional dummy encoder mode_fixup function.
> drm/cirrus: removed optional dummy encoder mode_fixup function.
> drm/exynos: removed optional dummy encoder mode_fixup function.
> drm/gma500: removed optional dummy encoder mode_fixup function.
> drm/imx: removed optional dummy encoder mode_fixup function.
> drm/msm/mdp: removed optional dummy encoder mode_fixup function.
> drm/mgag200: removed optional dummy encoder mode_fixup function.
> drm/qxl: removed optional dummy encoder mode_fixup function.
> drm/radeon: removed optional dummy encoder mode_fixup function.
> drm/rockchip: removed optional dummy encoder mode_fixup function.
> drm/sti: removed optional dummy encoder mode_fixup function.
> drm/tilcdc: removed optional dummy encoder mode_fixup function.
>
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 --------
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 --------
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 --------
> drivers/gpu/drm/ast/ast_mode.c | 8 --------
> drivers/gpu/drm/bochs/bochs_kms.c | 8 --------
> drivers/gpu/drm/cirrus/cirrus_mode.c | 9 ---------
> drivers/gpu/drm/exynos/exynos_dp_core.c | 8 --------
> drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 --------
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 --------
> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 --------
> drivers/gpu/drm/gma500/cdv_intel_crt.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 1 -
> drivers/gpu/drm/gma500/gma_display.c | 7 -------
> drivers/gpu/drm/gma500/gma_display.h | 3 ---
> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 1 -
> drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 --------
> drivers/gpu/drm/imx/imx-ldb.c | 8 --------
> drivers/gpu/drm/imx/imx-tve.c | 8 --------
> drivers/gpu/drm/imx/parallel-display.c | 8 --------
> drivers/gpu/drm/mgag200/mgag200_mode.c | 8 --------
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_dsi_encoder.c | 8 --------
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_dtv_encoder.c | 8 --------
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 8 --------
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 9 ---------
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 8 --------
> drivers/gpu/drm/qxl/qxl_display.c | 9 ---------
> drivers/gpu/drm/radeon/atombios_encoders.c | 8 --------
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 --------
> drivers/gpu/drm/sti/sti_tvout.c | 10 ----------
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 ---------
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 9 ---------
> drivers/gpu/drm/udl/udl_encoder.c | 8 --------
> drivers/gpu/drm/virtio/virtgpu_display.c | 8 --------
> 33 files changed, 244 deletions(-)
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply
* Re: [PATCH v2 03/17] drm/exynos: removed optional dummy encoder mode_fixup function.
From: Patrik Jakobsson @ 2016-02-15 13:49 UTC (permalink / raw)
To: Carlos Palminha
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard,
David Airlie, jingoohan1, dri-devel, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <3768b670931572de51fca1102efa18d20dd770ee.1455540137.git.palminha@synopsys.com>
Hi Carlos
Any particular reason why this patch isn't squashed with patch 8/17?
Thanks
Patrik
On Mon, Feb 15, 2016 at 1:58 PM, Carlos Palminha
<CARLOS.PALMINHA@synopsys.com> wrote:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
>
> This patch set nukes all the dummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index e977a81..736115c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1597,13 +1597,6 @@ static int exynos_dsi_create_connector(struct drm_encoder *encoder)
> return 0;
> }
>
> -static bool exynos_dsi_mode_fixup(struct drm_encoder *encoder,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> static void exynos_dsi_mode_set(struct drm_encoder *encoder,
> struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> @@ -1623,7 +1616,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder,
> }
>
> static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = {
> - .mode_fixup = exynos_dsi_mode_fixup,
> .mode_set = exynos_dsi_mode_set,
> .enable = exynos_dsi_enable,
> .disable = exynos_dsi_disable,
> --
> 2.5.0
>
^ permalink raw reply
* [PATCH v2 17/17] drm/tilcdc: removed optional dummy encoder mode_fixup function.
From: Carlos Palminha @ 2016-02-15 13:01 UTC (permalink / raw)
To: dri-devel
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard, airlied,
jingoohan1, CARLOS.PALMINHA, patrik.r.jakobsson, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <cover.1455540137.git.palminha@synopsys.com>
mode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 ---------
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 9 ---------
2 files changed, 18 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 4dda6e2..8dcf02a 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -70,14 +70,6 @@ static void panel_encoder_dpms(struct drm_encoder *encoder, int mode)
mode == DRM_MODE_DPMS_ON ? 1 : 0);
}
-static bool panel_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- /* nothing needed */
- return true;
-}
-
static void panel_encoder_prepare(struct drm_encoder *encoder)
{
struct panel_encoder *panel_encoder = to_panel_encoder(encoder);
@@ -103,7 +95,6 @@ static const struct drm_encoder_funcs panel_encoder_funcs = {
static const struct drm_encoder_helper_funcs panel_encoder_helper_funcs = {
.dpms = panel_encoder_dpms,
- .mode_fixup = panel_encoder_mode_fixup,
.prepare = panel_encoder_prepare,
.commit = panel_encoder_commit,
.mode_set = panel_encoder_mode_set,
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 5052a8a..1c23017 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -80,14 +80,6 @@ static void tfp410_encoder_dpms(struct drm_encoder *encoder, int mode)
tfp410_encoder->dpms = mode;
}
-static bool tfp410_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- /* nothing needed */
- return true;
-}
-
static void tfp410_encoder_prepare(struct drm_encoder *encoder)
{
tfp410_encoder_dpms(encoder, DRM_MODE_DPMS_OFF);
@@ -112,7 +104,6 @@ static const struct drm_encoder_funcs tfp410_encoder_funcs = {
static const struct drm_encoder_helper_funcs tfp410_encoder_helper_funcs = {
.dpms = tfp410_encoder_dpms,
- .mode_fixup = tfp410_encoder_mode_fixup,
.prepare = tfp410_encoder_prepare,
.commit = tfp410_encoder_commit,
.mode_set = tfp410_encoder_mode_set,
--
2.5.0
^ permalink raw reply related
* [PATCH v2 16/17] drm/sti: removed optional dummy encoder mode_fixup function.
From: Carlos Palminha @ 2016-02-15 13:01 UTC (permalink / raw)
To: dri-devel
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard, airlied,
jingoohan1, CARLOS.PALMINHA, patrik.r.jakobsson, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <cover.1455540137.git.palminha@synopsys.com>
mode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/sti/sti_tvout.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index f2afcf5..24a3735 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -440,13 +440,6 @@ static void sti_tvout_encoder_dpms(struct drm_encoder *encoder, int mode)
{
}
-static bool sti_tvout_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void sti_tvout_encoder_mode_set(struct drm_encoder *encoder,
struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
@@ -486,7 +479,6 @@ static void sti_dvo_encoder_disable(struct drm_encoder *encoder)
static const struct drm_encoder_helper_funcs sti_dvo_encoder_helper_funcs = {
.dpms = sti_tvout_encoder_dpms,
- .mode_fixup = sti_tvout_encoder_mode_fixup,
.mode_set = sti_tvout_encoder_mode_set,
.prepare = sti_tvout_encoder_prepare,
.commit = sti_dvo_encoder_commit,
@@ -540,7 +532,6 @@ static void sti_hda_encoder_disable(struct drm_encoder *encoder)
static const struct drm_encoder_helper_funcs sti_hda_encoder_helper_funcs = {
.dpms = sti_tvout_encoder_dpms,
- .mode_fixup = sti_tvout_encoder_mode_fixup,
.mode_set = sti_tvout_encoder_mode_set,
.prepare = sti_tvout_encoder_prepare,
.commit = sti_hda_encoder_commit,
@@ -589,7 +580,6 @@ static void sti_hdmi_encoder_disable(struct drm_encoder *encoder)
static const struct drm_encoder_helper_funcs sti_hdmi_encoder_helper_funcs = {
.dpms = sti_tvout_encoder_dpms,
- .mode_fixup = sti_tvout_encoder_mode_fixup,
.mode_set = sti_tvout_encoder_mode_set,
.prepare = sti_tvout_encoder_prepare,
.commit = sti_hdmi_encoder_commit,
--
2.5.0
^ permalink raw reply related
* [PATCH v2 15/17] drm/rockchip: removed optional dummy encoder mode_fixup function.
From: Carlos Palminha @ 2016-02-15 13:01 UTC (permalink / raw)
To: dri-devel
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard, airlied,
jingoohan1, CARLOS.PALMINHA, patrik.r.jakobsson, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <cover.1455540137.git.palminha@synopsys.com>
mode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index f8f8f29..7766206 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -875,13 +875,6 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder)
clk_disable_unprepare(dsi->pclk);
}
-static bool dw_mipi_dsi_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static void dw_mipi_dsi_encoder_commit(struct drm_encoder *encoder)
{
struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder);
@@ -931,7 +924,6 @@ static void dw_mipi_dsi_encoder_commit(struct drm_encoder *encoder)
static struct drm_encoder_helper_funcs
dw_mipi_dsi_encoder_helper_funcs = {
- .mode_fixup = dw_mipi_dsi_encoder_mode_fixup,
.commit = dw_mipi_dsi_encoder_commit,
.mode_set = dw_mipi_dsi_encoder_mode_set,
.disable = dw_mipi_dsi_encoder_disable,
--
2.5.0
^ permalink raw reply related
* [PATCH v2 14/17] drm/radeon: removed optional dummy encoder mode_fixup function.
From: Carlos Palminha @ 2016-02-15 13:01 UTC (permalink / raw)
To: dri-devel
Cc: k.kozlowski, linux-samsung-soc, heiko, benjamin.gaignard, airlied,
jingoohan1, CARLOS.PALMINHA, patrik.r.jakobsson, virtualization,
linux-rockchip, kgene, p.zabel, vincent.abriou, linux-arm-kernel,
mark.yao
In-Reply-To: <cover.1455540137.git.palminha@synopsys.com>
mode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Signed-off-by: Carlos Palminha <palminha@synopsys.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/radeon/atombios_encoders.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c
index 01b20e1..1603751 100644
--- a/drivers/gpu/drm/radeon/atombios_encoders.c
+++ b/drivers/gpu/drm/radeon/atombios_encoders.c
@@ -2623,16 +2623,8 @@ radeon_atom_ext_dpms(struct drm_encoder *encoder, int mode)
}
-static bool radeon_atom_ext_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
static const struct drm_encoder_helper_funcs radeon_atom_ext_helper_funcs = {
.dpms = radeon_atom_ext_dpms,
- .mode_fixup = radeon_atom_ext_mode_fixup,
.prepare = radeon_atom_ext_prepare,
.mode_set = radeon_atom_ext_mode_set,
.commit = radeon_atom_ext_commit,
--
2.5.0
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox