Linux virtualization list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Carlier" <devnexen@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH net-next v2 1/2] vsock: support SO_INQ on stream sockets
Date: Thu, 15 Oct 2026 16:02:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-173123@kernel.org> (raw)
In-Reply-To: <20261015154334.3217358-2-devnexen@gmail.com>

> SO_INQ makes recvmsg() return the bytes left in the receive queue in an
> SCM_INQ cmsg, saving a SIOCINQ call per receive. AF_UNIX stream sockets
> support it, AF_VSOCK fails with ENOPROTOOPT.
> 
> Add it for SOCK_STREAM, reusing the hint already computed for io_uring.
> As with TCP_INQ, 1 is reported once the stream is finished so the caller
> reads again and sees EOF, and accepted sockets inherit the setting from
> the listener. No cmsg is sent when the transport cannot report the queue
> length.
> 
> SOCK_SEQPACKET is refused, as on AF_UNIX: its transport callback counts
> messages, not bytes.
> 
> Signed-off-by: David Carlier <devnexen@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015154334.3217358-1-devnexen@gmail.com?part=1


  reply	other threads:[~2026-10-15 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 15:43 [PATCH net-next v2 0/2] vsock: SO_INQ for stream sockets David Carlier
2026-10-15 15:43 ` [PATCH net-next v2 1/2] vsock: support SO_INQ on " David Carlier
2026-10-15 16:02   ` sashiko-bot [this message]
2026-10-15 17:07   ` Bobby Eshleman
2026-10-16  8:14   ` Stefano Garzarella
2026-10-19  6:43   ` netdev-bot+sashiko
2026-10-15 15:43 ` [PATCH net-next v2 2/2] vsock/test: cover SO_INQ David Carlier
2026-10-15 16:02   ` sashiko-bot
2026-10-15 17:12   ` Bobby Eshleman
2026-10-16  8:15   ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-173123@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=devnexen@gmail.com \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox