From: sashiko-bot@kernel.org
To: shao.mingyin@zte.com.cn, virtualization@lists.linux.dev
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] virtio-blk: Fix zone append sector reporting in batched completion
Date: Mon, 26 Oct 2026 12:11:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-185178@kernel.org> (raw)
In-Reply-To: <202610261955196384aSLGuy3_0MiTvlYXVdiC@zte.com.cn>
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> For zone append, the block layer copies req->__sector back into the
> bio in blk_zone_append_update_request_bio(), so the driver must update
> req->__sector with the sector reported by the device.
> virtblk_request_done() does that, but the batched completion path used
> by virtblk_poll() only unmaps and cleans up the requests before calling
> blk_mq_end_request_batch().
>
> A zone append completed through polling therefore keeps the sector that
> was assigned at submission time, and the file system or application sees
> the wrong LBA for the written data.
>
> Move the sector update into a helper and call it from both completion
> paths.
>
> Fixes: 95bfec41bd3d ("virtio-blk: add support for zoned block devices")
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/202610261955196384aSLGuy3_0MiTvlYXVdiC@zte.com.cn?part=1
next prev parent reply other threads:[~2026-10-26 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:55 [PATCH] virtio-blk: Fix zone append sector reporting in batched completion shao.mingyin
2026-10-26 12:11 ` sashiko-bot [this message]
2026-10-27 15:06 ` Christoph Hellwig
[not found] ` <2026102810270846959TfFOThssBqrSo1PlP9X@zte.com.cn>
2026-11-03 8:02 ` Christoph Hellwig
2026-11-03 8:02 ` Christoph Hellwig
2026-10-27 19:17 ` Stefan Hajnoczi
2026-10-27 19:19 ` Michael S. Tsirkin
2026-11-03 14:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185178@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shao.mingyin@zte.com.cn \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox