From: sashiko-bot@kernel.org
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v3 16/22] gpio: virtio: Use a named initializer for virtio_device_id array
Date: Mon, 26 Oct 2026 16:32:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-185525@kernel.org> (raw)
In-Reply-To: <214191c76607fa156b8c9d9209ec8f4e49a4b44d.1793030820.git.u.kleine-koenig@baylibre.com>
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> This patch doesn't modify the compiled array, only its representation in
> source form benefits.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793030820.git.u.kleine-koenig@baylibre.com?part=16
next prev parent reply other threads:[~2026-10-26 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 16:28 [PATCH v3 00/22] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-26 16:28 ` [PATCH v3 16/22] gpio: virtio: Use a named initializer for virtio_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-26 16:32 ` sashiko-bot [this message]
2026-10-26 16:28 ` [PATCH v3 22/22] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-26 16:33 ` sashiko-bot
2026-10-26 16:38 ` [PATCH v3 00/22] gpio: Improvements around device-id arrays Frank Li
2026-10-27 9:41 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185525@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox