From: sashiko-bot@kernel.org
To: "Bart Van Assche" <bvanassche@acm.org>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] drm/qxl: Fix a missing unreserve in an error path
Date: Mon, 26 Oct 2026 20:05:57 +0000 [thread overview]
Message-ID: <sashiko-outbox-185702@kernel.org> (raw)
In-Reply-To: <4879712fc70d92a04de63eb81a673cd3d023af80.1793044836.git.bvanassche@acm.org>
> If qxl_bo_reserve() succeeds and ttm_bo_validate() fails,
> qxl_update_area_ioctl() returns without calling qxl_bo_unreserve().
> This leaves the buffer object reserved and causes later attempts to
> reserve it to hang. Fix this by calling qxl_bo_unreserve() in that
> error path.
>
> This has been detected by the Clang thread-safety analyzer.
> Compile-tested only.
>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: virtualization@lists.linux.dev
> Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/4879712fc70d92a04de63eb81a673cd3d023af80.1793044836.git.bvanassche@acm.org?part=1
prev parent reply other threads:[~2026-10-26 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 20:00 [PATCH] drm/qxl: Fix a missing unreserve in an error path Bart Van Assche
2026-10-26 20:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185702@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bvanassche@acm.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox