From: sashiko-bot@kernel.org
To: "Jianping Liu" <frankljpliu@gmail.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] drm/qxl: Fix oops caused by missing free_irq on device teardown
Date: Wed, 28 Oct 2026 09:37:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-187684@kernel.org> (raw)
In-Reply-To: <20261028092137.1372286-1-frankljpliu@gmail.com>
> From: Jianping Liu <frankjpliu@tencent.com>
>
> After qxl.ko is unloaded, reading /proc/interrupts triggers an oops.
> qxl_irq_init() requests the PCI IRQ with the DRM device as dev_id, but
> qxl_device_fini() never frees it. The IRQ action therefore stays
> registered, and its name still points into the unloaded module.
>
> To fix the oops, free the IRQ in qxl_device_fini() with the same
> dev_id passed to request_irq().
>
> Cc: stable@kernel.org
> Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
> Signed-off-by: Jianping Liu <frankjpliu@tencent.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028092137.1372286-1-frankljpliu@gmail.com?part=1
prev parent reply other threads:[~2026-10-28 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:21 [PATCH] drm/qxl: Fix oops caused by missing free_irq on device teardown Jianping Liu
2026-10-28 9:37 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187684@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=frankljpliu@gmail.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox