Re: [PATCH v7 12/16] ALSA: virtio: complete control transitions and preserve drain tail

[sashiko-bot@kernel.org]

> Pending signals can interrupt synchronous PCM state changes or the RX
> teardown wait after the device has accepted the command. Recovery can then
> issue a conflicting request before the previous transition has completed.
> Wait for SET_PARAMS, PREPARE and START within the existing timeout, as for
> STOP and RELEASE, and make the pending-RX drain wait non-interruptible.
> Device reset still cancels the wait and the timeout remains bounded.
> 
> Track whether a control request was submitted. Expose that information to
> the pause-restart state machine so it can distinguish a definitive failure
> from a timeout or reset after submission. The next patch uses this helper.
> 
> Keep INTEGER64 control values in the aligned response-data allocation
> instead of placing them immediately after the four-byte response header.
> 
> Capture DRAINING must allow consumption of the remaining tail without
> queueing fresh RX requests. Permit its indirect ACK while stopped and skip
> the refill in the transfer callback. A non-staged drain test returned
> -EPIPE with v5; the corrected kernel returned the final frame.
> 
> These changes address Sashiko findings in patches 1, 5 and 6 of this
> series. They apply after the included prerequisites.
> 
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028094132.20364-1-mynameisjune111@gmail.com?part=12