From: sashiko-bot@kernel.org
To: "Zenghui Yu" <zenghui.yu@linux.dev>, virtualization@lists.linux.dev
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v2] virtio_pci: don't take the MSI mutex under cpu_hotplug_lock
Date: Thu, 29 Oct 2026 12:21:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-189276@kernel.org> (raw)
In-Reply-To: <20261029121648.22155-1-zenghui.yu@linux.dev>
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
>
> Lockdep reports the following circular locking dependency when a virtio-net
> device is probed with lockdep enabled on a system whose devices sit behind
> an IOMMU:
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 7.3.0-rc1+ #84 Not tainted
> ------------------------------------------------------
> kworker/u34:0/57 is trying to acquire lock:
> ffff800104f83ee8 (&md->mutex){+.+.}-{4:4}, at: msi_domain_get_virq+0xf0/0x118
>
> but task is already holding lock:
> ffffc00081edd930 (cpu_hotplug_lock){++++}-{0:0}, at: cpus_read_lock+0x10/0x1c
> [ ... ]
> This also covers the CPU hotplug callbacks
> (virtnet_cpu_online/virtnet_cpu_dead), which call virtnet_set_affinity()
> with cpu_hotplug_lock already held.
>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029121648.22155-1-zenghui.yu@linux.dev?part=1
prev parent reply other threads:[~2026-10-29 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 12:16 [PATCH v2] virtio_pci: don't take the MSI mutex under cpu_hotplug_lock Zenghui Yu
2026-10-29 12:21 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189276@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=zenghui.yu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox