From: sashiko-bot@kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux.dev, "Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH RFC v7 5/5] net: add a sysctl to opt out of virtio net hdr checksum validation
Date: Fri, 30 Oct 2026 18:54:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-191421@kernel.org> (raw)
In-Reply-To: <7ff59e838eba4b63768327dfe553d6d9cac6afbf.1793276116.git.mst@redhat.com>
> The ingress validation as implemented by the previous
> patch is stricter than what it replaced: GSO
> packets whose checksum metadata matches no transport header are
> dropped, and non-GSO ones get their checksum completed in place.
> Such packets used to pass with the metadata unvalidated,
> and with no overhead.
>
> I judge that this should not affect any deployments, but there is still
> some risk that it does. In case a deployment depends on them anyway,
> provide a per-netns switch to get the old behavior back:
>
> echo 0 > /proc/sys/net/core/virtio_net_hdr_validate
>
> The default is validating.
>
> Reviewed-by: Björn Töpel <bjorn@kernel.org>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/305bcadb19f4a539a318c6b87c829fbe43d0ffdb.1793276116.git.mst@redhat.com?part=5
prev parent reply other threads:[~2026-10-30 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 11:59 [PATCH RFC v7 0/5] more virtio-net csum hardening Michael S. Tsirkin
2026-10-29 18:53 ` [PATCH RFC v7 1/5] net: account for ingress-resolved virtio net hdr state Michael S. Tsirkin
2026-10-30 18:54 ` sashiko-bot
2026-10-29 18:53 ` [PATCH RFC v7 2/5] um: vector: trim skbs before verifying the header Michael S. Tsirkin
2026-10-30 18:54 ` sashiko-bot
2026-10-29 18:53 ` [PATCH RFC v7 3/5] virtio_net: parse tunnel csum_start little-endian Michael S. Tsirkin
2026-10-30 18:54 ` sashiko-bot
2026-10-29 18:53 ` [PATCH RFC v7 4/5] net: resolve uncommon partial checksums at ingress Michael S. Tsirkin
2026-10-30 18:54 ` sashiko-bot
2026-10-30 19:21 ` Willem de Bruijn
2026-10-30 22:49 ` Michael S. Tsirkin
2026-10-30 21:28 ` Chris Arges
2026-10-29 18:53 ` [PATCH RFC v7 5/5] net: add a sysctl to opt out of virtio net hdr checksum validation Michael S. Tsirkin
2026-10-30 18:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-191421@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox