From: sashiko-bot@kernel.org
To: "Zack Rusin" <zack.rusin@broadcom.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v3 1/1] x86/vmware: Allocate shared storage for steal-time counters
Date: Tue, 03 Nov 2026 07:26:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-194710@kernel.org> (raw)
In-Reply-To: <52b57836c0c28abe1c4157646b39329c603ff77f.1792471114.git.zack.rusin@broadcom.com>
> Steal time accounts for time a virtual CPU waits to run on the host.
> VMware updates a counter in guest memory, but encrypted guests currently
> register private memory which the host cannot write.
>
> Allocate the counters together instead of embedding them in every CPU's
> per-CPU area, and share them before registering any address. Move setup
> for all guests to an early initcall, after the page allocator is available
> and before secondary CPUs start, so it can use the normal conversion API.
>
> Keep the allocation for CPU hotplug. Enable accounting only after boot-CPU
> registration succeeds, and retain pages whose encryption state is unknown
> on failure. A secondary CPU's registration failure must not prevent the
> other CPUs from unregistering their counters.
>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Link: https://lore.kernel.org/r/20261001235950.GHar7z9v3zfk8odoTh@fat_crate.local
> Link: https://lore.kernel.org/r/20260309235250.2611115-5-alexey.makhalov@broadcom.com
> Co-developed-by: Bo Gan <bo.gan@broadcom.com>
> Signed-off-by: Bo Gan <bo.gan@broadcom.com>
> Co-developed-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1792471114.git.zack.rusin@broadcom.com?part=1
prev parent reply other threads:[~2026-11-03 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 7:20 [PATCH v3 0/1] x86/vmware: Share steal-time counters in encrypted guests Zack Rusin
2026-11-03 7:20 ` [PATCH v3 1/1] x86/vmware: Allocate shared storage for steal-time counters Zack Rusin
2026-11-03 7:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194710@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox