From: sashiko-bot@kernel.org
To: "Thorsten Blum" <blum@kernel.org>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH 1/2] hwrng: virtio - simplify probe_common()
Date: Tue, 03 Nov 2026 16:54:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-195754@kernel.org> (raw)
In-Reply-To: <20261103165026.454333-3-blum@kernel.org>
> Drop the redundant NULL initialization since vi is immediately
> reassigned. Drop the redundant index variable and use vi->index
> directly. Also call ida_free() directly and consolidate the error
> cleanup paths.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103165026.454333-3-blum@kernel.org?part=1
prev parent reply other threads:[~2026-11-03 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 16:50 [PATCH 1/2] hwrng: virtio - simplify probe_common() Thorsten Blum
2026-11-03 16:50 ` [PATCH 2/2] hwrng: virtio - simplify virtrng_restore() Thorsten Blum
2026-11-03 16:55 ` sashiko-bot
2026-11-03 16:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195754@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=blum@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox