Linux virtualization list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nikolaos Karaolidis" <nick@karaolidis.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH RFC 1/6] mm/memory_hotplug: add and export mhp_memmap_on_memory_nr_pages()
Date: Wed, 04 Nov 2026 09:51:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-197000@kernel.org> (raw)
In-Reply-To: <20261103-virtio-mem-memmap-v1-1-308ae1da6240@karaolidis.com>

> virtio-mem wants to add memory with MHP_MEMMAP_ON_MEMORY. It has to
> know at probe time how many pages at the start of each memory block
> will host the memmap. Those pages never reach the buddy, so they must
> not be fake-offlined, and in Sub Block Mode they must stay plugged while
> the memory block is added.
> 
> memory_block_memmap_on_memory_pages() returns a non-zero value even if
> the core would ignore MHP_MEMMAP_ON_MEMORY, and recomputing the value in
> the driver would duplicate the padding of
> "memory_hotplug.memmap_on_memory=force". Add a helper that returns the
> number of memmap pages, or 0 if the flag would be ignored. Both inputs
> are fixed after boot.
> 
> Assisted-by: LLM
> Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-virtio-mem-memmap-v1-0-308ae1da6240@karaolidis.com?part=1


  reply	other threads:[~2026-11-04  9:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  9:50 [PATCH RFC 0/6] virtio-mem: support memmap_on_memory Nikolaos Karaolidis
2026-11-03  9:50 ` [PATCH RFC 1/6] mm/memory_hotplug: add and export mhp_memmap_on_memory_nr_pages() Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot [this message]
2026-11-03  9:50 ` [PATCH RFC 2/6] virtio-mem: prepare memory notifier for a self-hosted memmap Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot
2026-11-03  9:50 ` [PATCH RFC 3/6] virtio-mem: support memmap_on_memory in Big Block Mode Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot
2026-11-03  9:50 ` [PATCH RFC 4/6] virtio-mem: move virtio_mem_sbm_try_remove_unplugged_mb() Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot
2026-11-03  9:50 ` [PATCH RFC 5/6] virtio-mem: support memmap_on_memory in Sub Block Mode Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot
2026-11-03  9:50 ` [PATCH RFC 6/6] Documentation/admin-guide/mm: document virtio-mem memmap_on_memory Nikolaos Karaolidis
2026-11-04  9:51   ` sashiko-bot
2026-11-03 16:29 ` [PATCH RFC 0/6] virtio-mem: support memmap_on_memory David Hildenbrand (Arm)
2026-11-03 17:37   ` Nick Karaolidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-197000@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=nick@karaolidis.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox