From: sashiko-bot@kernel.org
To: "Gu Bin" <gubin@cmss.chinamobile.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] tools/virtio/virtio_test: advance next_reset by reset_n, not completed
Date: Thu, 05 Nov 2026 07:51:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-198699@kernel.org> (raw)
In-Reply-To: <20261105074741.2177-1-gubin@cmss.chinamobile.com>
> run_test() arms the next device reset with
>
> while (completed > next_reset)
> next_reset += completed;
>
> next_reset starts at reset_n, but each rearm advances the threshold by
> the absolute completion count instead of the configured interval, so
> the reset cadence stretches after every reset: with reset_n == 16 the
> resets fire at completions 17, 34, 68, 136, ... instead of every 16
> completions, and only a handful of resets happen over the whole run.
>
> Advance next_reset by reset_n so resets stay evenly spaced, matching
> the --reset=<n> option meaning.
>
> Fixes: 264ee5aa81ec ("tools/virtio: Add --reset")
> Signed-off-by: Gu Bin <gubin@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105074741.2177-1-gubin@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-05 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 7:47 [PATCH] tools/virtio/virtio_test: advance next_reset by reset_n, not completed Gu Bin
2026-11-05 7:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198699@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=gubin@cmss.chinamobile.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox