From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794450085; b=ii7MpINaT33Ngj3LVlj4VRzSN29571JZm6H051giGOdgBrmQk8mQM6QPtCZ4VJNlpd0k l7UmDxi8awqHvzDnWFB+tZSTLRmcUYTl2YbVXX/STAbv+san/u01ecqpgfHJ/SB0/ecHi noeDR/Ef1CaW883UPKcB1tZvLpRFfOR6V2flX74b2X5Z54ScLOpSXtqAhaOXnWpkNdxx4 5CAideHAtRePoqm+UG8ugRoeQRdHLZIO7J+rgsLpk9qIUuuJCCprrX8qNqtfrkYFWsDA/ YQMKqulbXA0NXstLp9uEucx1ynsVINzpPCGQva57byvK/wVuyvwKa7G0SJQDuAP9P5Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794450085; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=qT1YzmrqfWzzxrPBUQQgohnst4d28Q4NF92z4tZ+9NI=; b=FUZ6yBJEz2e61+0DszSG6yUPLspLyHqENx/5S7Q1RNZhqwxNOXetQ6AAa/qMaxaNqusF /iIzPuSwIU0S0rk7PJzBHiESAOdfUiZZU+jcEj+xbuzAaIY7g/LtOsurZexHvkIIAUI0+ Upzk9qziVkyuU7RtvoBVdgmZzEN8n0nzDA61UURk7ChgsvaYholi3wxu1UieEjmIsLoHe Nq5YNFwNphZHNFYovTigP5+sTWIR1pk3mZfhkGu021nmhUlT8e2wS7kgGI9IbOYzTL/AI //jHhLheVzciqhtQlnURinZTClWEfqiWGZm+0hnNhKASmt0iqysJitC9CU3eV2WCE0A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LlAVygZ6; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9891606A31C for ; Thu, 12 Nov 2026 02:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LlAVygZ6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33BA91F00A05; Thu, 12 Nov 2026 02:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794450085; bh=qT1YzmrqfWzzxrPBUQQgohnst4d28Q4NF92z4tZ+9NI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=LlAVygZ6+prGBVojJqOAB6LBn+RS283AcEKtYvJ2xNLz5jmVmvrAcoTvcQpPxc2HQ aVzPQx4GbTiWDwweiRstTWrBRH+tjUns5WOK3mKbhOla8OQS/WMnpUaUmdbYjE8xWu +//Waqtd2ofo3LyzeoIWKxkkLAbOurXOZQ7kJizEuUwHdSpUgsMZnN+Vo7TZw06CXG MVkfOcPwOSdMnzqAeTfygrsfaLX4NFjJxYQ0p47ghmbIkFHw6JOn8ToDw8QBNfJ+lv +8enNb9fv8nAkpuevB7+4FyC7bhE6aI3utK5hpSx+NLSychSoqYvRYYwW8gVPJnlra OkLKg/H2fzh/A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v27 08/17] ALSA: virtio: Retain queued messages through device reset Reply-To: sashiko-reviews@lists.linux.dev To: "Joonho Lee" Cc: virtualization@lists.linux.dev, "Michael S. Tsirkin" , "Eugenio Perez" In-Reply-To: <20261112004704.49758-9-mynameisjune111@gmail.com> References: <20261112004704.49758-1-mynameisjune111@gmail.com> <20261112004704.49758-9-mynameisjune111@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 12 Nov 2026 02:21:24 +0000 X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Keep the control queue available through snd_card_free() so close-time > STOP and RELEASE commands can still be submitted. Block new control > requests and mark pending messages canceled before reset, then release > their queue references only after reset and queue deletion. >=20 > For PCM queues, detach each remaining virtqueue buffer after the device > has stopped DMA and retire its message without reporting a normal > completion. Detach all queues before deleting them so outstanding DMA > mappings are unmapped and no token remains for a late device completion. >=20 > Protect event callback admission with the event queue lock. Disabling > events waits for an active dispatch, and later callbacks see a closed > gate before ALSA objects are freed. Enable and pending-event draining > share the same lock. >=20 > Reclaim pending event buffers after a failed probe without dispatching > notifications into ALSA objects that have not been constructed. Record > the queue's prior enabled state under its lock before closing admission. >=20 > Track successful virtqueue initialization so teardown and failed restore > cleanup call del_vqs() only for an initialized queue set. >=20 > Fixes: 9d45e514da88 ("ALSA: virtio: handling control messages") > Assisted-by: LLM > Signed-off-by: Joonho Lee Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261112004704.4975= 8-1-mynameisjune111@gmail.com?part=3D8