From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v33 16/18] ALSA: pcm: add an explicit application pointer to indirect playback transfer
Date: Fri, 13 Nov 2026 09:36:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-212555@kernel.org> (raw)
In-Reply-To: <20261113-fix-virtio-snd-recovery-final-v33-16-13a934ad5ece@gmail.com>
> From: Joonho Lee <mynameisjune111@gmail.com>
>
> The indirect playback transfer helper samples runtime->control->appl_ptr
> internally. A driver that needs to refill already committed data from a
> pointer callback cannot pass the application-pointer snapshot used for
> ACK validation.
>
> Add snd_pcm_indirect_playback_transfer_appl_ptr() so callers can supply
> that snapshot. Keep snd_pcm_indirect_playback_transfer() as a wrapper
> that samples the runtime pointer as before, preserving existing callers.
>
> The explicit-pointer form lets virtio refill accepted data without
> accepting new application progress while the ALSA buffer-access gate is
> closed.
>
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-fix-virtio-snd-recovery-final-v33-0-13a934ad5ece@gmail.com?part=16
next prev parent reply other threads:[~2026-11-13 9:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 9:21 [PATCH v33 00/18] ALSA: virtio: preserve PCM progress Joonho Lee via B4 Relay
2026-11-13 9:21 ` [PATCH v33 01/18] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee via B4 Relay
2026-11-13 9:26 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 02/18] ALSA: pcm: report partial progress under the stream lock Joonho Lee via B4 Relay
2026-11-13 9:34 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 03/18] ALSA: pcm: add an optional reset operation " Joonho Lee via B4 Relay
2026-11-13 9:30 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 04/18] ALSA: pcm: notify drivers after linked prepare completes Joonho Lee via B4 Relay
2026-11-13 9:36 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 05/18] ALSA: pcm: serialize linked buffer actions Joonho Lee via B4 Relay
2026-11-13 9:31 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 06/18] ALSA: virtio: propagate playback send failures through ACK Joonho Lee via B4 Relay
2026-11-13 9:48 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 07/18] ALSA: virtio: Recover PCM state after a failed start Joonho Lee via B4 Relay
2026-11-13 9:47 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 08/18] ALSA: virtio: Retain queued messages through device reset Joonho Lee via B4 Relay
2026-11-13 9:46 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 09/18] ALSA: virtio: bound PCM transfers and retain DMA buffers Joonho Lee via B4 Relay
2026-11-13 9:54 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 10/18] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee via B4 Relay
2026-11-13 9:30 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 11/18] ALSA: virtio: wait through signals for PCM teardown Joonho Lee via B4 Relay
2026-11-13 9:38 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 12/18] ALSA: virtio: use request-owned capture and serialize recovery Joonho Lee via B4 Relay
2026-11-13 9:49 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 13/18] ALSA: virtio: prioritize capture period work Joonho Lee via B4 Relay
2026-11-13 9:33 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 14/18] docs: describe virtio-sound capture options Joonho Lee via B4 Relay
2026-11-13 9:33 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 15/18] ALSA: virtio: reject invalid playback completions Joonho Lee via B4 Relay
2026-11-13 9:45 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 16/18] ALSA: pcm: add an explicit application pointer to indirect playback transfer Joonho Lee via B4 Relay
2026-11-13 9:36 ` sashiko-bot [this message]
2026-11-13 9:21 ` [PATCH v33 17/18] ALSA: virtio: preserve playback progress across pause and buffer access Joonho Lee via B4 Relay
2026-11-13 9:48 ` sashiko-bot
2026-11-13 9:21 ` [PATCH v33 18/18] ALSA: virtio: settle PCM control state from late replies Joonho Lee via B4 Relay
2026-11-13 9:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212555@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=mynameisjune111@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox