Linux virtualization list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zack Rusin" <zack.rusin@broadcom.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v4 2/3] x86/vmware: Route low-bandwidth hypercalls through a static call
Date: Wed, 18 Nov 2026 06:53:07 +0000	[thread overview]
Message-ID: <sashiko-outbox-220276@kernel.org> (raw)
In-Reply-To: <7c77ebf56fe48daad11a0de31ff41785364e5029.1794206170.git.zack.rusin@broadcom.com>

> From: Alexey Makhalov <alexey.makhalov@broadcom.com>
> 
> The low-bandwidth wrappers duplicate inline assembly for the backdoor,
> vmcall and vmmcall paths, and each repeats the TDX check. The early boot
> path also needs a separate dispatcher until alternatives have been
> patched.
> 
> Move the assembly into four backends selected by a static call. Pass the
> command with input and result structures instead of ten arguments with
> nullable output pointers, as suggested by Linus. Keep the existing wrapper
> API for callers.
> 
> The backdoor remains the link-time target for early DMI probing. TDX
> guests cannot use its I/O port, so it forwards them to the TDX backend,
> which still rejects other hypervisors such as KVM. Each backend fills
> the complete result structure. The backdoor replaces the low 16 bits of
> %edx with its port; vmcall, vmmcall and TDX preserve them. Export only
> the GPL trampoline so modules can call it but cannot retarget it.
> 
> The selected static call also makes vmware_hypercall_slow() obsolete.
> Remove it in the same change so no runtime code refers to the init-only
> mode byte. Print the selected backend by name instead of its numeric mode.
> 
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Co-developed-by: Zack Rusin <zack.rusin@broadcom.com>
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794206170.git.zack.rusin@broadcom.com?part=2


  reply	other threads:[~2026-11-18  6:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:40 [PATCH v4 0/3] x86/vmware: Clean up the hypercall code Zack Rusin
2026-11-18  6:40 ` [PATCH v4 1/3] x86/vmware: Move high-bandwidth hypercalls out of line Zack Rusin
2026-11-18  6:53   ` sashiko-bot
2026-11-18  6:40 ` [PATCH v4 2/3] x86/vmware: Route low-bandwidth hypercalls through a static call Zack Rusin
2026-11-18  6:53   ` sashiko-bot [this message]
2026-11-18  6:40 ` [PATCH v4 3/3] x86/cpufeatures: Remove unused VMware hypercall feature bits Zack Rusin
2026-11-18  6:43   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220276@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox