From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>
Cc: Srujana Challa <schalla@marvell.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
pabeni@redhat.com, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
andrew+netdev@lunn.ch, davem@davemloft.net,
ndabilpuram@marvell.com,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY_LEN
Date: Thu, 22 Jan 2026 14:32:28 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.113a625cf37a9@gmail.com> (raw)
In-Reply-To: <CANn89iL5s+egLhothNtnQf0jtAeftezUjNmbuXtUWgfVV3+bzg@mail.gmail.com>
Eric Dumazet wrote:
> On Thu, Jan 22, 2026 at 4:52 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Thu, 22 Jan 2026 14:45:27 +0530 Srujana Challa wrote:
> > > Increase VIRTIO_NET_RSS_MAX_KEY_SIZE from 40 to 52 bytes to align with
> > > the kernel's standard RSS key length defined by NETDEV_RSS_KEY_LEN.
> >
> > I've been meaning to bump NETDEV_RSS_KEY_LEN to 128 or some such.
> > Most modern drivers can't use netdev_rss_key_fill() either because
> > core generates a tiny key. And the devices support hashing over two
> > layers of IPv6 for tunnels.
>
> Seems fine to me. Back in 2014, RSS was limited to 52 bytes on all known NIC.
What is the purpose of extending?
The current length is sufficient for standard Toeplitz 4-tuple hashing.
next prev parent reply other threads:[~2026-01-22 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 9:15 [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY_LEN Srujana Challa
2026-01-22 10:15 ` Michael S. Tsirkin
2026-01-23 11:37 ` [EXTERNAL] " Srujana Challa
2026-01-22 15:52 ` Jakub Kicinski
2026-01-22 16:13 ` Eric Dumazet
2026-01-22 16:17 ` Eric Dumazet
2026-01-22 16:52 ` Jakub Kicinski
2026-01-22 19:32 ` Willem de Bruijn [this message]
2026-01-22 19:42 ` Willem de Bruijn
2026-01-23 11:46 ` [EXTERNAL] " Srujana Challa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.113a625cf37a9@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=schalla@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox