From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed Date: Tue, 10 Sep 2019 22:14:12 -0400 Message-ID: References: <20190905181903.29756-1-mlupfer@ddn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190905181903.29756-1-mlupfer@ddn.com> (Matt Lupfer's message of "Thu, 5 Sep 2019 18:19:28 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Matt Lupfer Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "mst@redhat.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "stefanha@redhat.com" , "pbonzini@redhat.com" , "jejb@linux.ibm.com" List-Id: virtualization@lists.linuxfoundation.org Matt, > The event handler calls scsi_scan_host() when events are missed, which > will hotplug new LUNs. However, this function won't remove any > unplugged LUNs. The result is that hotunplug doesn't work properly > when the number of unplugged LUNs exceeds the event queue size > (currently 8). > > Scan existing LUNs when events are missed to check if they are still > present. If not, remove them. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering