* Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed [not found] <20190905181903.29756-1-mlupfer@ddn.com> @ 2019-09-06 8:54 ` Stefan Hajnoczi [not found] ` <20190906085409.GC5900@stefanha-x1.localdomain> 2019-09-11 2:14 ` Martin K. Petersen 2 siblings, 0 replies; 3+ messages in thread From: Stefan Hajnoczi @ 2019-09-06 8:54 UTC (permalink / raw) To: Matt Lupfer Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, pbonzini@redhat.com, jejb@linux.ibm.com [-- Attachment #1.1: Type: text/plain, Size: 909 bytes --] On Thu, Sep 05, 2019 at 06:19:28PM +0000, Matt Lupfer wrote: > The event handler calls scsi_scan_host() when events are missed, which > will hotplug new LUNs. However, this function won't remove any > unplugged LUNs. The result is that hotunplug doesn't work properly when > the number of unplugged LUNs exceeds the event queue size (currently 8). > > Scan existing LUNs when events are missed to check if they are still > present. If not, remove them. > > Signed-off-by: Matt Lupfer <mlupfer@ddn.com> > --- > drivers/scsi/virtio_scsi.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) Please include a changelog in future patch revisions. For example: Signed-off-by: ... --- v2: * Replaced magic constants with sd.h constants [Michael] Just C and virtio code review, no SCSI specifics: Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20190906085409.GC5900@stefanha-x1.localdomain>]
* Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed [not found] ` <20190906085409.GC5900@stefanha-x1.localdomain> @ 2019-09-09 16:55 ` Paolo Bonzini 0 siblings, 0 replies; 3+ messages in thread From: Paolo Bonzini @ 2019-09-09 16:55 UTC (permalink / raw) To: Stefan Hajnoczi, Matt Lupfer Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, jejb@linux.ibm.com [-- Attachment #1.1.1: Type: text/plain, Size: 1041 bytes --] On 06/09/19 10:54, Stefan Hajnoczi wrote: > On Thu, Sep 05, 2019 at 06:19:28PM +0000, Matt Lupfer wrote: >> The event handler calls scsi_scan_host() when events are missed, which >> will hotplug new LUNs. However, this function won't remove any >> unplugged LUNs. The result is that hotunplug doesn't work properly when >> the number of unplugged LUNs exceeds the event queue size (currently 8). >> >> Scan existing LUNs when events are missed to check if they are still >> present. If not, remove them. >> >> Signed-off-by: Matt Lupfer <mlupfer@ddn.com> >> --- >> drivers/scsi/virtio_scsi.c | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) > > Please include a changelog in future patch revisions. For example: > > Signed-off-by: ... > --- > v2: > * Replaced magic constants with sd.h constants [Michael] > > Just C and virtio code review, no SCSI specifics: > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed [not found] <20190905181903.29756-1-mlupfer@ddn.com> 2019-09-06 8:54 ` [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed Stefan Hajnoczi [not found] ` <20190906085409.GC5900@stefanha-x1.localdomain> @ 2019-09-11 2:14 ` Martin K. Petersen 2 siblings, 0 replies; 3+ messages in thread From: Martin K. Petersen @ 2019-09-11 2:14 UTC (permalink / raw) To: Matt Lupfer Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, stefanha@redhat.com, pbonzini@redhat.com, jejb@linux.ibm.com Matt, > The event handler calls scsi_scan_host() when events are missed, which > will hotplug new LUNs. However, this function won't remove any > unplugged LUNs. The result is that hotunplug doesn't work properly > when the number of unplugged LUNs exceeds the event queue size > (currently 8). > > Scan existing LUNs when events are missed to check if they are still > present. If not, remove them. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-11 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190905181903.29756-1-mlupfer@ddn.com>
2019-09-06 8:54 ` [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed Stefan Hajnoczi
[not found] ` <20190906085409.GC5900@stefanha-x1.localdomain>
2019-09-09 16:55 ` Paolo Bonzini
2019-09-11 2:14 ` Martin K. Petersen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).