From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jan Hoeppner" <hoeppner@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
"Song Liu" <song@kernel.org>,
dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
"Jack Wang" <jinpu.wang@ionos.com>,
linux-s390@vger.kernel.org, "Richard Weinberger" <richard@nod.at>,
xen-devel@lists.xenproject.org, linux-um@lists.infradead.org,
"Mike Snitzer" <snitzer@kernel.org>,
"Josef Bacik" <josef@toxicpanda.com>,
nbd@other.debian.org, linux-block@vger.kernel.org,
"Stefan Haberland" <sth@linux.ibm.com>,
"Jens Axboe" <axboe@kernel.dk>,
linux-raid@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: fix and cleanup discard_alignment handling
Date: Tue, 26 Apr 2022 00:16:21 -0400 [thread overview]
Message-ID: <yq1tuagv5xw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220418045314.360785-1-hch@lst.de> (Christoph Hellwig's message of "Mon, 18 Apr 2022 06:53:03 +0200")
Christoph,
> the somewhat confusing name of the discard_alignment queue limit, that
> really is an offset for the discard granularity mislead a lot of
> driver authors to set it to an incorrect value. This series tries to
> fix up all these cases.
Not sure how I ended up with "discard_alignment" when I called the
corresponding I/O parameter "alignment_offset".
Anyway. All this looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-26 4:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 4:53 fix and cleanup discard_alignment handling Christoph Hellwig
2022-04-18 4:53 ` [PATCH 01/11] ubd: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 4:53 ` [PATCH 02/11] nbd: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 03/11] null_blk: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits Christoph Hellwig
2022-04-18 4:53 ` [PATCH 05/11] dm-zoned: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 4:53 ` [PATCH 06/11] raid5: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 07/11] dasd: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 08/11] loop: remove a spurious clear of discard_alignment Christoph Hellwig
2022-04-18 4:53 ` [PATCH 09/11] nvme: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 10/11] rnbd-srv: use bdev_discard_alignment Christoph Hellwig
2022-04-18 4:53 ` [PATCH 11/11] xen-blkback: " Christoph Hellwig
2022-04-26 4:16 ` Martin K. Petersen [this message]
2022-05-02 16:46 ` fix and cleanup discard_alignment handling Christoph Hellwig
2022-05-03 16:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tuagv5xw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=jinpu.wang@ionos.com \
--cc=johannes@sipsolutions.net \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=sth@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).