Re: [PATCH RFC 10/35] mm/hugetlb: cleanup hugetlb_folio_init_tail_vmemmap()

David Hildenbrand
2025-08-22T06:40:35Z

On 22.08.25 06:09, Mika Penttilä wrote:
>
> On 8/21/25 23:06, David Hildenbrand wrote:
>
>> All pages were already initialized and set to PageReserved() with a
>> refcount of 1 by MM init code.
>
> Just to be sure, how is this working with MEMBLOCK_RSRV_NOINIT, where MM is supposed not to
> initialize struct pages?

Excellent point, I did not know about that one.

Spotting that we don't do the same for the head page made me assume that
it's just a misuse of __init_single_page().

But the nasty thing is that we use memblock_reserved_mark_noinit() to
only mark the tail pages ...

Let me revert back to __init_single_page() and add a big fat comment why
this is required.

Thanks!

--
Cheers

David / dhildenb