From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2D66C2D0CD for ; Wed, 21 May 2025 13:06:52 +0000 (UTC) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 20d6f183; Tue, 20 May 2025 19:38:32 +0000 (UTC) Received: from nyc.source.kernel.org (nyc.source.kernel.org [2604:1380:45d1:ec00::3]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 512460ef (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 8 Jan 2025 17:31:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9978EA40C9E; Wed, 8 Jan 2025 17:29:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A24C4CED3; Wed, 8 Jan 2025 17:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736357500; bh=nFNghkqYK0OyBrmna6riJjtdRf/DJ2kks0ygjdBlGVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dHciAqjYDmfJ4f1GrLA+k2mHdvH/PcVoEoaHp5l6oKUNCl2H/rGngM0bwH32RiDGA RKqyu4tcA5nz7uUemz8c9pBwQy5/Yl8okpkaljtV2r2hG4AolL+jj/8d3xoqFgJj/k A8Gm9TIsj/lz+b3kQ9boVv/nZhWvr6TKHL4QkMBonYptSr9cZeQpQoKuXcOHybpkHo e98f1a4tvA5J5nyWISRW/K9JoOD2UBjXudUvXF9tlj/7wrEctr/u5Qqq3QhEk/fT8p UuTt5BSsN/f7ZpDAzFwxdIWvEiqXFx0/T5vxvOySo2ialJKoOi0JYP1ThEhqIye8Rl dB8lzKIIuuacA== Date: Wed, 8 Jan 2025 09:31:39 -0800 From: Jakub Kicinski To: Xiao Liang Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Kuniyuki Iwashima , Donald Hunter , "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , Ido Schimmel , Andrew Lunn , Simon Horman , Shuah Khan , Jiri Pirko , Hangbin Liu , linux-rdma@vger.kernel.org, linux-can@vger.kernel.org, osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org, linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com, linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, bridge@lists.linux.dev, linux-wpan@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v7 02/11] rtnetlink: Pack newlink() params into struct Message-ID: <20250108093139.126716e9@kernel.org> In-Reply-To: References: <20250104125732.17335-1-shaw.leon@gmail.com> <20250104125732.17335-3-shaw.leon@gmail.com> <20250107123805.748080ab@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" On Wed, 8 Jan 2025 16:36:26 +0800 Xiao Liang wrote: > On Wed, Jan 8, 2025 at 4:38=E2=80=AFAM Jakub Kicinski w= rote: > > > > On Sat, 4 Jan 2025 20:57:23 +0800 Xiao Liang wrote: =20 > > > -static int amt_newlink(struct net *net, struct net_device *dev, > > > - struct nlattr *tb[], struct nlattr *data[], > > > - struct netlink_ext_ack *extack) > > > +static int amt_newlink(struct rtnl_newlink_params *params) > > > { > > > - struct amt_dev *amt =3D netdev_priv(dev); > > > + struct netlink_ext_ack *extack =3D params->extack; > > > + struct net_device *dev =3D params->dev; > > > + struct nlattr **data =3D params->data; > > > + struct nlattr **tb =3D params->tb; > > > + struct net *net =3D params->net; > > > + struct amt_dev *amt; =20 > > > > IMHO you packed a little too much into the struct. > > Could you take the dev and the extack back out? =20 >=20 > Sure. I thought you were suggesting packing them all > in review of v3... Sorry about that, I wasn't very clear :( What I had in mind was similar to how we define ethtool ops, (especially the more recent ones which have extack) for example: int (*set_mm)(struct net_device *dev, struct ethtool_mm_cfg *cfg, struct netlink_ext_ack *extack);