From: Xiao Liang <shaw.leon@gmail.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org,
linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
bridge@lists.linux.dev, linux-wpan@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()
Date: Wed, 19 Feb 2025 20:50:31 +0800 [thread overview]
Message-ID: <20250219125039.18024-6-shaw.leon@gmail.com> (raw)
In-Reply-To: <20250219125039.18024-1-shaw.leon@gmail.com>
ip_tunnel_init() is called from register_netdevice(). In all code paths
reaching here, tunnel->net should already have been set (either in
ip_tunnel_newlink() or __ip_tunnel_create()). So don't set it again.
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
---
net/ipv4/ip_tunnel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 09b73acf037a..dd4b4e5be998 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -1326,7 +1326,6 @@ int ip_tunnel_init(struct net_device *dev)
}
tunnel->dev = dev;
- tunnel->net = dev_net(dev);
strscpy(tunnel->parms.name, dev->name);
iph->version = 4;
iph->ihl = 5;
--
2.48.1
next prev parent reply other threads:[~2025-05-21 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250219125039.18024-1-shaw.leon@gmail.com>
2025-02-19 12:50 ` [PATCH net-next v10 02/13] rtnetlink: Pack newlink() params into struct Xiao Liang
2025-02-19 12:50 ` [PATCH net-next v10 03/13] net: Use link/peer netns in newlink() of rtnl_link_ops Xiao Liang
2025-02-19 12:50 ` [PATCH net-next v10 04/13] ieee802154: 6lowpan: Validate link " Xiao Liang
2025-02-19 12:50 ` Xiao Liang [this message]
2025-02-21 3:26 ` [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init() Kuniyuki Iwashima
2025-02-19 12:50 ` [PATCH net-next v10 06/13] net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops Xiao Liang
2025-02-21 3:35 ` Kuniyuki Iwashima
2025-02-19 12:50 ` [PATCH net-next v10 07/13] net: ipv6: Init tunnel link-netns before registering dev Xiao Liang
2025-02-21 4:06 ` Kuniyuki Iwashima
2025-02-19 12:50 ` [PATCH net-next v10 08/13] net: ipv6: Use link netns in newlink() of rtnl_link_ops Xiao Liang
2025-02-21 4:08 ` Kuniyuki Iwashima
2025-02-19 12:50 ` [PATCH net-next v10 09/13] net: xfrm: " Xiao Liang
2025-02-19 12:50 ` [PATCH net-next v10 10/13] rtnetlink: Remove "net" from newlink params Xiao Liang
2025-02-21 4:11 ` Kuniyuki Iwashima
2025-02-19 12:50 ` [PATCH net-next v10 11/13] rtnetlink: Create link directly in target net namespace Xiao Liang
2025-02-19 12:50 ` [PATCH net-next v10 13/13] selftests: net: Add test cases for link and peer netns Xiao Liang
2025-02-21 23:47 ` [PATCH net-next v10 00/13] net: Improve netns handling in rtnetlink Jakub Kicinski
2025-02-21 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219125039.18024-6-shaw.leon@gmail.com \
--to=shaw.leon@gmail.com \
--cc=alex.aring@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).