From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Simon Horman" <horms@kernel.org>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, "Jordan Rife" <jordan@jrife.io>
Subject: [PATCH net-next v3 09/11] wireguard: netlink: convert to split ops
Date: Wed, 5 Nov 2025 18:32:18 +0000 [thread overview]
Message-ID: <20251105183223.89913-10-ast@fiberby.net> (raw)
In-Reply-To: <20251105183223.89913-1-ast@fiberby.net>
This patch converts wireguard from using legacy struct genl_ops
to struct genl_split_ops, by applying the same transformation
as genl_cmd_full_to_split() would otherwise do at runtime.
WGDEVICE_A_MAX is swapped for WGDEVICE_A_PEERS, while they are
currently equivalent, then .maxattr should be the maximum attribute
that a given command supports, which might not be WGDEVICE_A_MAX.
This is an incremental step towards adopting netlink policy code
generated by ynl-gen, ensuring that the code and spec is aligned.
This is a trivial patch with no behavioural changes intended.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/wireguard/netlink.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c
index f9bed135000f..7fecc25bd781 100644
--- a/drivers/net/wireguard/netlink.c
+++ b/drivers/net/wireguard/netlink.c
@@ -616,28 +616,30 @@ static int wg_set_device(struct sk_buff *skb, struct genl_info *info)
return ret;
}
-static const struct genl_ops genl_ops[] = {
+static const struct genl_split_ops wireguard_nl_ops[] = {
{
.cmd = WG_CMD_GET_DEVICE,
.start = wg_get_device_start,
.dumpit = wg_get_device_dump,
.done = wg_get_device_done,
- .flags = GENL_UNS_ADMIN_PERM
+ .policy = device_policy,
+ .maxattr = WGDEVICE_A_PEERS,
+ .flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DUMP,
}, {
.cmd = WG_CMD_SET_DEVICE,
.doit = wg_set_device,
- .flags = GENL_UNS_ADMIN_PERM
+ .policy = device_policy,
+ .maxattr = WGDEVICE_A_PEERS,
+ .flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DO,
}
};
static struct genl_family genl_family __ro_after_init = {
- .ops = genl_ops,
- .n_ops = ARRAY_SIZE(genl_ops),
+ .split_ops = wireguard_nl_ops,
+ .n_split_ops = ARRAY_SIZE(wireguard_nl_ops),
.name = WG_GENL_NAME,
.version = WG_GENL_VERSION,
- .maxattr = WGDEVICE_A_MAX,
.module = THIS_MODULE,
- .policy = device_policy,
.netnsok = true
};
--
2.51.0
next prev parent reply other threads:[~2025-11-19 21:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 18:32 [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 01/11] wireguard: netlink: validate nested arrays in policy Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 02/11] wireguard: netlink: use WG_KEY_LEN in policies Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 03/11] wireguard: netlink: enable strict genetlink validation Asbjørn Sloth Tønnesen
2025-11-18 15:15 ` Jason A. Donenfeld
2025-11-18 17:10 ` Jason A. Donenfeld
2025-11-26 16:24 ` Asbjørn Sloth Tønnesen
2025-11-26 16:26 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 04/11] netlink: specs: add specification for wireguard Asbjørn Sloth Tønnesen
2025-11-18 2:15 ` Jason A. Donenfeld
2025-11-18 12:08 ` Asbjørn Sloth Tønnesen
2025-11-18 15:07 ` Jason A. Donenfeld
2025-11-18 21:59 ` Asbjørn Sloth Tønnesen
2025-11-18 22:52 ` Jason A. Donenfeld
2025-11-19 0:50 ` Jakub Kicinski
2025-11-19 19:19 ` Asbjørn Sloth Tønnesen
2025-11-19 19:22 ` Jason A. Donenfeld
2025-11-19 19:47 ` Asbjørn Sloth Tønnesen
2025-11-19 20:01 ` Jason A. Donenfeld
2025-11-20 2:27 ` Jakub Kicinski
2025-11-05 18:32 ` [PATCH net-next v3 05/11] uapi: wireguard: move enum wg_cmd Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 06/11] uapi: wireguard: move flag enums Asbjørn Sloth Tønnesen
2025-11-18 15:10 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 07/11] uapi: wireguard: generate header with ynl-gen Asbjørn Sloth Tønnesen
2025-11-18 15:17 ` Jason A. Donenfeld
2025-11-19 0:53 ` Jakub Kicinski
2025-11-20 0:55 ` Jason A. Donenfeld
2025-11-05 18:32 ` [PATCH net-next v3 08/11] tools: ynl: add sample for wireguard Asbjørn Sloth Tønnesen
2025-11-18 15:20 ` Jason A. Donenfeld
2025-11-18 17:16 ` Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` Asbjørn Sloth Tønnesen [this message]
2025-11-05 18:32 ` [PATCH net-next v3 10/11] wireguard: netlink: rename netlink handlers Asbjørn Sloth Tønnesen
2025-11-05 18:32 ` [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code Asbjørn Sloth Tønnesen
2025-11-18 15:15 ` Jason A. Donenfeld
2025-11-18 16:57 ` Jason A. Donenfeld
2025-11-18 22:23 ` Asbjørn Sloth Tønnesen
2025-11-18 22:51 ` Jason A. Donenfeld
2025-11-19 1:00 ` Jakub Kicinski
2025-11-20 0:54 ` Jason A. Donenfeld
2025-11-20 2:44 ` Jakub Kicinski
2025-11-20 2:46 ` Jason A. Donenfeld
2025-11-20 3:19 ` Jakub Kicinski
2025-11-20 19:49 ` Asbjørn Sloth Tønnesen
2025-11-11 2:07 ` [PATCH net-next v3 00/11] wireguard: netlink: ynl conversion Jakub Kicinski
2025-11-12 3:59 ` Jason A. Donenfeld
2025-11-18 0:14 ` Jakub Kicinski
2025-11-18 0:43 ` Jason A. Donenfeld
2025-11-18 0:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105183223.89913-10-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jordan@jrife.io \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox