From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C0A7CF648C for ; Wed, 19 Nov 2025 23:07:50 +0000 (UTC) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 01fcf593; Wed, 19 Nov 2025 01:00:53 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [2600:3c04:e001:324:0:1991:8:25]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 7ceea59f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 19 Nov 2025 01:00:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D92A66014A; Wed, 19 Nov 2025 01:00:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DBA8C16AAE; Wed, 19 Nov 2025 01:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763514048; bh=CQjZ0N89SVdwQBbPJ9aCn3Gqm4WwXY0obje6FxdqVi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ByKHzKNVLOSLn5LEw/fWzSjuif5JJLGakx1Tgrd8qkQe2MPOT3tQ6mow1lI+10WE0 8bGknq3Y1JL6fh17+RlVvn6pak65A9gpgOW4nTaCB/thLahgGL98lucmYQR9PPwFf4 pPhsme4RVZhMDlnc9I6Jh7IdZkCrIkgzl0TQFyY7nZBXIrIDtw5A3SFUV4BBDcNCUl E27Bi3x7+HfH0GSgOFvSUyrNAOu7nku315vyMQ0oaoAa5dEpG1FfeQSg0ObytjWJjD KCfoE6AqWjoLj4DVY6KuoAUvTxO8i1dkNyLBlexQiolgPPSimIreBiyS6pL378bPRh XdZGFKOHdEGiA== Date: Tue, 18 Nov 2025 17:00:45 -0800 From: Jakub Kicinski To: "Jason A. Donenfeld" Cc: =?UTF-8?B?QXNiasO4cm4=?= Sloth =?UTF-8?B?VMO4bm5lc2Vu?= , Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jacob Keller , Andrew Lunn , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jordan Rife Subject: Re: [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code Message-ID: <20251118170045.0c2e24f7@kernel.org> In-Reply-To: References: <20251105183223.89913-1-ast@fiberby.net> <20251105183223.89913-12-ast@fiberby.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" On Tue, 18 Nov 2025 23:51:37 +0100 Jason A. Donenfeld wrote: > I mean, there is *tons* of generated code in the kernel. This is how it > works. And you *want the output to change when the tool changes*. That's > literally the point. It would be like if you wanted to check in all the > .o files, in case the compiler started generating different output, or > if you wanted the objtool output or anything else to be checked in. And > sheerly from a git perspective, it seems outrageous to touch a zillion > files every time the ynl code changes. Rather, the fact that it's > generated on the fly ensures that the ynl generator stays correctly > implemented. It's the best way to keep that code from rotting. CI checks validate that the files are up to date. There has been no churn to the kernel side of the generated code. Let's be practical.