From: Xiao Liang <shaw.leon@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Donald Hunter <donald.hunter@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Hangbin Liu <liuhangbin@gmail.com>,
linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org,
linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
bridge@lists.linux.dev, linux-wpan@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 11/11] selftests: net: Add test cases for link and peer netns
Date: Thu, 19 Dec 2024 13:54:03 +0800 [thread overview]
Message-ID: <CABAhCORszq9ao3OCVW-1EBsxsnLxbQ096eV+cbs12Es2HvCgUA@mail.gmail.com> (raw)
In-Reply-To: <20241218153759.672b7014@kernel.org>
On Thu, Dec 19, 2024 at 7:38 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 18 Dec 2024 21:09:09 +0800 Xiao Liang wrote:
> > - Add test for creating link in another netns when a link of the same
> > name and ifindex exists in current netns.
> > - Add test to verify that link is created in target netns directly -
> > no link new/del events should be generated in link netns or current
> > netns.
> > - Add test cases to verify that link-netns is set as expected for
> > various drivers and combination of namespace-related parameters.
>
> Nice work!
>
> You need to make sure all the drivers the test is using are enabled by
> the selftest kernel config: tools/testing/selftests/net/config
>
> This may be helpful:
> https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#how-to-build
Thanks for pointing it out. And vng is really cool. I will add
the missing config in the next version.
> --
> pw-bot: cr
prev parent reply other threads:[~2025-05-21 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 13:08 [PATCH net-next v6 00/11] net: Improve netns handling in rtnetlink Xiao Liang
2024-12-18 13:08 ` [PATCH net-next v6 01/11] rtnetlink: Lookup device in target netns when creating link Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 02/11] rtnetlink: Pack newlink() params into struct Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 03/11] net: Use link netns in newlink() of rtnl_link_ops Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 04/11] ieee802154: 6lowpan: " Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 05/11] net: ip_tunnel: " Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 06/11] net: ipv6: " Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 07/11] net: xfrm: " Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 08/11] rtnetlink: Remove "net" from newlink params Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 09/11] rtnetlink: Create link directly in target net namespace Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 10/11] selftests: net: Add python context manager for netns entering Xiao Liang
2024-12-18 13:09 ` [PATCH net-next v6 11/11] selftests: net: Add test cases for link and peer netns Xiao Liang
2024-12-18 23:37 ` Jakub Kicinski
2024-12-19 5:54 ` Xiao Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABAhCORszq9ao3OCVW-1EBsxsnLxbQ096eV+cbs12Es2HvCgUA@mail.gmail.com \
--to=shaw.leon@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).