From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B033F606A31A for ; Mon, 26 Oct 2026 06:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KHpEGv+p Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id b21a545a; Mon, 26 Oct 2026 05:29:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 6a63e1d1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 20 Oct 2026 09:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792488291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BznN/lY8tjRKb0k1WwnLhH6cM8dWen14mRHzzd6dYZk=; b=KHpEGv+pbn3XxbjvQXVpQ/61VD9M1gWuSyFWqoRH5gRNWA3B1PvfXU2Pp0NTP5PjNGCBES MxP0RX+nGboHQlEKowVAeiRjy7c0dEKVBZSBTdvk2wEtZ99KRMBHQfGu5/zIUrkQ32lyYE KYJOydbgRjnlGG5rYYgxefloA9GxZ4Y= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-yQTXnxNLNOSym5LCND7XSQ-1; Tue, 20 Oct 2026 09:24:47 +0000 X-MC-Unique: yQTXnxNLNOSym5LCND7XSQ-1 X-Mimecast-MFC-AGG-ID: yQTXnxNLNOSym5LCND7XSQ_1792488285 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1459F18007F6; Tue, 20 Oct 2026 09:24:45 +0000 (UTC) Received: from onestero-thinkpadp1gen7.tpbc.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id B3A68418; Tue, 20 Oct 2026 09:24:41 +0000 (UTC) Received: by onestero-thinkpadp1gen7.tpbc.csb (nbSMTP-1.00) for uid 13628 oleg@redhat.com; Tue, 20 Oct 2026 11:24:44 +0200 (CEST) Date: Tue, 20 Oct 2026 11:24:40 +0200 From: Oleg Nesterov To: Joel Granados Cc: Allison Henderson , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, wireguard@lists.zx2c4.com, rds-devel@oss.oracle.com Subject: Re: [linus:master] [sysctl] 8d75c338f0: BUG:KASAN:slab-use-after-free_in_touch_wq_lockdep_map Message-ID: References: <202610190310.9737b2e3-lkp@intel.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-MFC-PROC-ID: 1eSncJt9anJ_rmpcIfbvsa9Kvpht0FDarR48L1qH53Q_1792488285 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailman-Approved-At: Mon, 26 Oct 2026 05:28:33 +0000 X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "WireGuard" X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/20, Joel Granados wrote: > > You can also do this (also untested and not compiled): > > diff --git i/net/rds/ib_sysctl.c w/net/rds/ib_sysctl.c > index 2af678e71e3c6..bc97a3eecad69 100644 > --- i/net/rds/ib_sysctl.c > +++ w/net/rds/ib_sysctl.c > @@ -114,7 +114,7 @@ void rds_ib_sysctl_exit(void) > int rds_ib_sysctl_init(void) > { > rds_ib_sysctl_hdr = register_net_sysctl(&init_net, "net/rds/ib", rds_ib_sysctl_table); > - if (!rds_ib_sysctl_hdr) > + if (!rds_ib_sysctl_hdr && IS_ENABLED(CONFIG_SYSCTL)) > return -ENOMEM; > return 0; > } > diff --git i/net/rds/sysctl.c w/net/rds/sysctl.c > index 025f518a43495..41c65b98c94bd 100644 > --- i/net/rds/sysctl.c > +++ w/net/rds/sysctl.c > @@ -93,7 +93,8 @@ static struct ctl_table rds_sysctl_rds_table[] = { > > void rds_sysctl_exit(void) > { > - unregister_net_sysctl_table(rds_sysctl_reg_table); > + if (rds_sysctl_reg_table) > + unregister_net_sysctl_table(rds_sysctl_reg_table); Yes, this is what Allison suggested too. But he also pointed out that the changes in _exit() are not strictly needed, unregister_net_sysctl_table is nop if !CONFIG_SYSCTL. Plus we also need to change rds_tcp_init_net() the same way, see register_net_sysctl_sz(). So, let me repeat, I agree in advance with anything you and Allison prefer. Oleg.