From: Simon Horman <horms@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
netdev@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net] docs: netdev: Document guidance on inline functions
Date: Tue, 4 Feb 2025 09:35:26 +0000 [thread overview]
Message-ID: <20250204093526.GK234677@kernel.org> (raw)
In-Reply-To: <a2ae1cda-8210-4e6c-86ea-0ee864e13b23@lunn.ch>
On Mon, Feb 03, 2025 at 04:10:24PM +0100, Andrew Lunn wrote:
> > Conversely, spelling and grammar fixes are not discouraged.
> >
> > +Inline functions
> > +----------------
> > +
> > +The use of static inline functions in .c file is strongly discouraged
>
> I don't think 'static' is relevant here. They probably are static, if
> they are inline, and to avoid warnings about missing declarations. But
> we just prefer not to have any sort of inline functions without good
> justifications within a .c file.
>
> A nit pick, so:
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks Andrew,
I agree that static is not helpful here, I'll drop that in a v2.
next prev parent reply other threads:[~2025-02-04 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 13:59 [PATCH net] docs: netdev: Document guidance on inline functions Simon Horman
2025-02-03 15:00 ` Jonathan Corbet
2025-02-03 19:50 ` Mauro Carvalho Chehab
2025-02-03 19:53 ` Mauro Carvalho Chehab
2025-02-04 11:55 ` Simon Horman
2025-02-04 11:54 ` Simon Horman
2025-02-04 13:25 ` Andrew Lunn
2025-02-04 20:07 ` Simon Horman
2025-02-04 22:46 ` David Laight
2025-02-03 15:10 ` Andrew Lunn
2025-02-04 9:35 ` Simon Horman [this message]
2025-02-03 18:51 ` Randy Dunlap
2025-02-04 11:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204093526.GK234677@kernel.org \
--to=horms@kernel.org \
--cc=alexandre.ferrieux@gmail.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).